Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Add aria-label to page jump #33075

Closed
2 of 4 tasks
m2-assistant bot opened this issue May 25, 2021 · 2 comments · Fixed by #33067
Closed
2 of 4 tasks

[Issue] Add aria-label to page jump #33075

m2-assistant bot opened this issue May 25, 2021 · 2 comments · Fixed by #33067
Assignees
@bradleybrecher
Labels
Component: Theme Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
High Priority Backlog

Comments

@m2-assistant
Copy link

m2-assistant bot commented May 25, 2021

This issue is automatically created based on existing pull request: #33067: Add aria-label to page jump

Description (*)

Issue : 2.4.4 Link Purpose (In Context))

Summary: The same link text, ... is used for links going to different page jumps. Users might not know the difference between each ... if there is no explanation

Fix: Add an 'aria-label' which indicates the page the user is skipping to

Related Pull Requests

N/A

Fixed Issues (if relevant)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot mentioned this issue May 25, 2021
Merged
5 tasks
@m2-community-project m2-community-project bot added this to Ready for Confirmation in Issue Confirmation and Triage Board May 25, 2021
@m2-community-project m2-community-project bot added Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels May 25, 2021
@Den4ik Den4ik added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels May 26, 2021
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog May 26, 2021
@m2-community-project m2-community-project bot removed this from Ready for Confirmation in Issue Confirmation and Triage Board May 26, 2021
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @Den4ik
Thank you for verifying the issue. Based on the provided information internal tickets MC-42469 were created

Issue Available: @Den4ik, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@sidolov
Copy link
Contributor

sidolov commented Sep 23, 2021

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #33067 by @bradleybrecher in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.3 release.

@sidolov sidolov added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Sep 23, 2021
@sidolov sidolov closed this as completed Sep 23, 2021
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bradleybrecher bradleybrecher

Labels
Component: Theme Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
High Priority Backlog
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add aria-label to page jump bradleybrecher/magento2
4 participants
@Den4ik @sidolov @magento-engcom-team @bradleybrecher