Add aria-label to page jump

[bradleybrecher]

Description (*)

Issue : 2.4.4 Link Purpose (In Context))

Summary: The same link text, ... is used for links going to different page jumps. Users might not know the difference between each ... if there is no explanation

Fix: Add an 'aria-label' which indicates the page the user is skipping to

Related Pull Requests

N/A

Fixed Issues (if relevant)

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Add aria-label to page jump #33075: Add aria-label to page jump

[m2-assistant]

Hi @bradleybrecher. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[bradleybrecher]

I will not make a test for this addition, so someone feel free to add it

[gabrieldagama]

@magento create issue

[blmage]

Can you translate this?

[bradleybrecher]

@blmage can you clarify further what you mean by "translate this"?

[Den4ik]

@bradleybrecher 'Skip to Page' should be translatable with __()

[bradleybrecher]

change pushed & ready for another review

[Den4ik]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Den4ik]

@engcom-Alfa I don't know how you tests it, but QA Passed for me

Actual Result

[magento-engcom-team]

Hi @Den4ik, thank you for the review.
ENGCOM-9108 has been created to process this Pull Request

[Den4ik]

@engcom-Alfa Looks like I understood.
Looks like you set ... to Anchor Text for Previous and Anchor Text for Next

Please follow little bit different scenario:

1. Set Pagination Frame Skip to 1

[engcom-Alfa]

@magento run Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Alfa]

@magento run Functional Tests CE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Alfa]

@magento run Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Alfa]

@engcom-Alfa Looks like I understood.
Looks like you set ... to Anchor Text for Previous and Anchor Text for Next

Please follow little bit different scenario:

1. Set Pagination Frame Skip to 1

Thank you so much for the input @Den4ik ! This helped to proceed further. Thanks a lot

[engcom-Alfa]

✔️ QA Passed

Preconditions:

1. Install a fresh Magento instance with sample data.

Manual testing scenario:

1. Login to admin and navigate to Content>Configuration>Pagination

2. Set the Pagination Frame to 2; Set the Pagination Frame Skip to 1; Save the changes (Admin>Content>Design>Configuration> Select Global Default website > Pagination)

3. Front end: Navigate to Women>Tops; Scroll down the product listed page and check the pagination content with inspected tag's attributes.

Before: ✖️ There was no aria-label attribute to the link text ...

After: ✔️ aria-label attribute has been set to the link text ...

There is no additional regression is required since it is a aria-label attribute update to a particular link.

[m2-assistant]

Hi @bradleybrecher, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.