Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsubscribe link doesn't work anymore #33310

Closed
LeoNun opened this issue Jun 21, 2021 · 15 comments · Fixed by #33753
Closed

unsubscribe link doesn't work anymore #33310

LeoNun opened this issue Jun 21, 2021 · 15 comments · Fixed by #33753
Assignees
Labels
Area: Content Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.2.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reproduced on 2.4.2

Comments

@LeoNun
Copy link

LeoNun commented Jun 21, 2021

Hello, I´m having an issue since I installed magento 2.4, and now still have the problem in magento 2.4.2-p1. The unsubscribe link doesn't work in the newsletter since magento 2.3.5.

The unsubscribe link for both is the same, {{var subscriber.getUnsubscriptionLink()}}

When I check over the unsubscribe link in a newsletter sent with magento 2.4.2 I get a blank page, as it fallows:

1

Before in magento 2.3.5, a link was generated to unsubscribe, as:

2

I've found some people with the same issue but nothing in concret to solve the problem.

Is this a bug already reported? Any solution?

Please find more details about the issue below:
#33310 (comment)

Best Regards,
Leonel Nunes

@m2-assistant
Copy link

m2-assistant bot commented Jun 21, 2021

Hi @LeoNun. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-assistant
Copy link

m2-assistant bot commented Jun 21, 2021

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@LeoNun
Copy link
Author

LeoNun commented Jun 21, 2021

Hello,
I can confirm that the problem of the customer edit page is fixed, so it displays as it showld but the unsubscription doesn't work.

Best regards,
Leonel Nunes

@engcom-November
Copy link

engcom-November commented Jun 21, 2021

Verified the issue on latest Magento version 2.4.2 and the issue is reproducible.
Blank page is displayed in the news Letter. Unsubscribe link is not getting displayed.
Preconditions:
Email configuration is setup on Magento (Ex: SMTP Gmail configuration)
Steps to reproduce:

  1. Magento Admin -> Customers -> All Customers -> Edit the Customer -> News Letter -> Subscribe to NewsLetter and save
  2. Marketing -> News Letter Template -> Add new template
  3. Marketing -> News Letter Template -> Actions -> Queue News Letter - edit and Save News Letter
  4. News Letter should be triggered to the Customer email ID. If not triggered, run magento cron job: sudo php bin/magento cron:run, emails would be triggered automatically after running cron.
    Issue: Blank page is displayed in News Letter email. Unsubscribe link is not displayed for any of the below configurations:

33310-1

33310-22

@engcom-November engcom-November added Reproduced on 2.4.2 Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jun 21, 2021
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Jun 21, 2021
@LeoNun
Copy link
Author

LeoNun commented Jun 21, 2021

Hello,
thank for the confirmation, I will wait for an hot fix for this issue.

Best regards,
Leonel Nunes

@gabrieldagama gabrieldagama added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Jun 22, 2021
@m2-community-project m2-community-project bot added this to Ready for Development in High Priority Backlog Jun 22, 2021
@SilinMykola
Copy link
Contributor

@magento I am working on this

@LeoNun
Copy link
Author

LeoNun commented Aug 10, 2021

Hello,
is this solved in magento 2.4.3 ?

Best regards,
Leonel Nunes

@shane-clickingmad
Copy link

Hello,
is this solved in magento 2.4.3 ?

Best regards,
Leonel Nunes

Doesn't appear so no

@grassst
Copy link

grassst commented Oct 11, 2021

Hi!
I have the same problem with 2.4.2-p1. I will verify it in 2.4.3...
Does anybody know a workarround?

Thank you!

Best regards,
Stefan

@LeoNun
Copy link
Author

LeoNun commented Oct 11, 2021

Hello,
actually Mr. SilinMykola fixed the problem, at list it works since I've implemented is fix and the unsubscribtion is now working.

Check https://github.com/magento/magento2/pull/33753/commits

Best regards,
Leonel Nunes

@rachel-dale
Copy link

Has anyone resolved this? I have tried a few different codes but the link never appears in the email

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog Feb 1, 2022
@engcom-Alfa engcom-Alfa added Area: Content Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reported on 2.2.x Indicates original Magento version for the Issue report. Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Feb 28, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-2509 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Feb 28, 2022

✅ Confirmed by @engcom-Alfa. Thank you for verifying the issue.
Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@MakoWish
Copy link

MakoWish commented Jan 7, 2023

I see this is closed, but I am running into the same issue with 8.4.4. The unsubscribe link is not being generated on Newsletter emails. I have not yet tried other emails.

@norgeindian
Copy link

@MakoWish , it is now generated using another syntax:

<a href="{{var subscriber_data.unsubscription_link}}">{{var subscriber_data.unsubscription_link}} </a> works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Content Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.2.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reproduced on 2.4.2
Projects
Development

Successfully merging a pull request may close this issue.