Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category theme is not applied to product #33428

Open
1 task
chaikivskyi opened this issue Jul 6, 2021 · 16 comments
Open
1 task

Category theme is not applied to product #33428

chaikivskyi opened this issue Jul 6, 2021 · 16 comments
Labels
Area: Catalog Component: Catalog Component: Theme Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: ready for dev Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Comments

@chaikivskyi
Copy link

Preconditions (*)

  1. Magento 2.4

Steps to reproduce (*)

  1. Configure a separate theme for the category on the category edit page in admin panel
  2. Enable " Apply Design to Products"
  3. Go to the product page

Expected result (*)

  1. Product use the same theme as a category

Actual result (*)

  1. Product use default theme

  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
@m2-assistant
Copy link

m2-assistant bot commented Jul 6, 2021

Hi @chaikivskyi. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@chaikivskyi
Copy link
Author

@magento I am working on this

@m2-assistant
Copy link

m2-assistant bot commented Jul 6, 2021

Hi @chaikivskyi! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

@engcom-November engcom-November self-assigned this Jul 6, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jul 6, 2021

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@mrtuvn
Copy link
Contributor

mrtuvn commented Jul 6, 2021

i can't reproduce problem like description
Tested with my own local instance (latest code 2.4-develop) + Sample product with luma default + same preconditions as your describe
Screenshot from 2021-07-06 22-12-35 (Category tops)
Screenshot from 2021-07-06 22-12-38 (Details of product Chaz Kangeroo Hoodie)
Empty category page (no products assigned)
Screenshot from 2021-07-07 08-59-53

@chaikivskyi
Copy link
Author

@mrtuvn I can't be sure that you understand the issue by your screenshots.
I can explain the issue on the code level.
7f6e9a8 - it is a related commit to this issue which exists in the 2.4-develop branch, but I think the author missed some details.
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Catalog/Controller/Product/View.php#L198 - in my opinion, we should setCategory to a product like in the https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Catalog/Helper/Product.php#L460. Because the function getDesignSettings do not return the right value from category when the product does not contain a category.

@mrtuvn
Copy link
Contributor

mrtuvn commented Jul 7, 2021

So i think you can update more details in preconditions for QA/QC team can easier reproduce your scenario
From my experience products in category list page already set category_id for each products listed in block. Reference this class app/code/Magento/Catalog/Block/Product/ListProduct.php
Feel free to create pull request if you want to cover missing case

@chaikivskyi
Copy link
Author

@mrtuvn Controller Product/View.php does not work on the product listing. It is a product page. Please, do next steps to reproduce the issue:

  1. Create a new theme
  2. Apply a theme for only one category and enable the setting Apply Design to Products https://imgur.com/zqHGfAG
  3. Create new layout rules for the catalog_product_view handle in the new theme. These rules will not be applied on the product page.

@engcom-November
Copy link
Contributor

engcom-November commented Jul 7, 2021

Verified the issue on Magento 2.4-develop branch and the issue is reproducible:
Default theme - Luma
Configured Magento Blank theme for the category on the category edit page in admin panel (Catalog -> Categories -> Add Root Category -> Design - Enable " Apply Design to Products" )
Navigate to Catalog - Products -> Add new product / Edit Product -> Assign the newly created Category and remove other categories if any.
Front End - Go to the product page - Default Theme is getting applied.
Actual Result: Default theme - Luma is applied
image

Expected behavior: - Magento theme should be applied.
image

Note: This issue is resolved only if Admin -> Catalog -. Products -> Edit Product -> Design section is also modified. (Magento Blank theme is applied in Design section)

@engcom-November engcom-November added Component: Theme Reported on 2.4.x Indicates original Magento version for the Issue report. Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Jul 7, 2021
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Jul 7, 2021
@mrtuvn mrtuvn added Component: Catalog Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Jul 8, 2021
@m2-community-project m2-community-project bot added this to Dev In Progress in High Priority Backlog Jul 8, 2021
@mrtuvn mrtuvn added Priority: P3 May be fixed according to the position in the backlog. and removed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Jul 8, 2021
@m2-community-project m2-community-project bot added this to Dev In Progress in Low Priority Backlog Jul 8, 2021
@m2-community-project m2-community-project bot removed this from Dev In Progress in High Priority Backlog Jul 8, 2021
@mrtuvn mrtuvn added the Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed label Jul 8, 2021
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in Low Priority Backlog Jul 20, 2021
@mrtuvn mrtuvn removed their assignment Jul 21, 2021
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Dev In Progress in Low Priority Backlog Jul 21, 2021
@mrtuvn
Copy link
Contributor

mrtuvn commented Jul 21, 2021

cc: @tsviklinskyi Can you check comment #33428 (comment)
Seem we miss specific case customer go directly to product without visit category page. In this case product may not contain category information so design will not apply

@chaikivskyi
Copy link
Author

chaikivskyi commented Jul 26, 2021

@mrtuvn The issue described in this ticket is not related to the case you described.

@engcom-November engcom-November added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Aug 8, 2022
@github-jira-sync-bot
Copy link

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

@github-jira-sync-bot github-jira-sync-bot removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Aug 8, 2022
@engcom-November engcom-November added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Area: Catalog labels Aug 8, 2022
@github-jira-sync-bot
Copy link

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

@github-jira-sync-bot github-jira-sync-bot removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Aug 8, 2022
@engcom-November engcom-November added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Aug 8, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-6316 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Aug 8, 2022

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@github-jira-sync-bot
Copy link

❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-6316

@m2-community-project m2-community-project bot moved this from Dev In Progress to Ready for Development in Low Priority Backlog Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Catalog Component: Catalog Component: Theme Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: ready for dev Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Low Priority Backlog
  
Ready for Development
Development

No branches or pull requests

4 participants