Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Multishipping::beforeSetShippingMethods() method can be simplified by removing unused $methods argument #3348

Closed
dmitrii-fediuk opened this issue Feb 9, 2016 · 3 comments
Closed

The Multishipping::beforeSetShippingMethods() method can be simplified by removing unused $methods argument #3348

dmitrii-fediuk opened this issue Feb 9, 2016 · 3 comments
Assignees
@ishakhsuvarov
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@dmitrii-fediuk
Copy link

https://mage2.pro/t/490

magento/devdocs#516, #3326
See also: #3340
@ishakhsuvarov
Copy link
Contributor

@dfediuk Thank you for reporting this issue. We have created an internal ticket MAGETWO-49548 to improve the method in question.

@ishakhsuvarov ishakhsuvarov added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report labels Feb 22, 2016
@okobchenko
Copy link
Contributor

@dfediuk We have investigated reported problem. Unused formal parameter was added for consistency between plugin and pluginized method. There is a convention requiring that "before" plugin receives subject (instance of pluginized object) and list of input parameter of pluginized method. Theoretically particular code can work with $methods argument removed, but this will decrease visibility of relation between methods and arguments exchange and is not recommended practice.

@ishakhsuvarov
Copy link
Contributor

@dfediuk Closing this issue for now. Please feel free to reopen if you have any additional questions.

magento-engcom-team pushed a commit that referenced this issue Oct 25, 2018
@igrybkov
Merge pull request #3348 from magento-tango/PR-2.2-1
fdcab41 
Fixed issues:
  - MAGETWO-95721: Removing Special Price changes final_price, min_price, max_price to 0.00
  - MAGETWO-94988: Image downsampling to 80% on the product page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ishakhsuvarov ishakhsuvarov

Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dmitrii-fediuk @ishakhsuvarov @okobchenko @MomotenkoNatalia