Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 compatibility for Magento Coding Standards #33564

Closed
github-jira-sync-bot opened this issue Jul 22, 2021 · 4 comments
Closed

PHP 8 compatibility for Magento Coding Standards #33564

github-jira-sync-bot opened this issue Jul 22, 2021 · 4 comments
Labels
has dependency Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Project: Platform Health

Comments

@github-jira-sync-bot
Copy link

 

What should be done

  1. Fix issues reported by dev-develop PHPCompatibility check:
composer config repositories.phpcompatibility vcs "https://github.com/PHPCompatibility/PHPCompatibility"
composer config minimum-stability dev
composer require phpcompatibility/php-compatibility:dev-develop
./vendor/bin/phpcs -p . --standard=PHPCompatibility
  1. Check and fix the areas not yet covered by PHPCompatibility on develop branch:

PHPCompatibility/PHPCompatibility#809

  1. Update PHP version in composer.json to include "~8.0.0"

  2. Update dependencies to versions supporting PHP 8 in composer.json. Ensure the project can be installed by the composer on both PHP 8 and PHP 7.4 environments.

  3. Deliver the changes to develop branch

  4. Release new version of Magento Coding Standards

  5. Update Magento Coding Standards version in Magento (composer.lock) and Marketplace

@github-jira-sync-bot
Copy link
Author

The issue was exported from the internal Jira. The link to the original Jira issue: https://jira.corp.magento.com/browse/AC-189

@m2-assistant
Copy link

m2-assistant bot commented Jul 22, 2021

Hi @github-jira-sync-bot. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added this to Ready for Confirmation in Issue Confirmation and Triage Board Jul 22, 2021
@sivaschenko sivaschenko added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Project: Platform Health labels Jul 22, 2021
@m2-community-project m2-community-project bot added this to Ready for Development in Platform Health Backlog Jul 22, 2021
@m2-community-project m2-community-project bot removed this from Ready for Confirmation in Issue Confirmation and Triage Board Jul 22, 2021
@ihor-sviziev
Copy link
Contributor

This issue depends on #33622

@andrewbess
Copy link

Currently this project is compatibility with PHP 8.
release-v7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has dependency Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Project: Platform Health
Projects
No open projects
Development

No branches or pull requests

4 participants