Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phpunit to the latest version for magento-coding-standard #33622

Closed
sivaschenko opened this issue Jul 28, 2021 · 8 comments · Fixed by magento/magento-coding-standard#219
Assignees
Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Project: Platform Health

Comments

@sivaschenko
Copy link
Member

sivaschenko commented Jul 28, 2021

Update PHPUnit to the latest version for magento-coding-standard repository.

This will also require update or elimination of PHP_CodeSniffer\Tests\Standards\AbstractSniffUnitTest dependency.

@sivaschenko sivaschenko added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Project: Platform Health labels Jul 28, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jul 28, 2021

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sivaschenko
Copy link
Member Author

@magento export issue to Jira project AC as Story

@korovitskyi
Copy link
Collaborator

@magento I am working on this

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Jul 29, 2021

FYI I tried to update to phpunit 8 or phpunit 9 - the unit tests of coding standard were failing with Fatal Errors due to missing void return type on setUp method on the https://github.com/squizlabs/PHP_CodeSniffer/blob/master/tests/Standards/AbstractSniffUnitTest.php#L55

@korovitskyi
Copy link
Collaborator

Hi, @ihor-sviziev , @sivaschenko .
I'm not sure that we can update PHPUnit version to 8 or 9(lastest).
As the dependency squizlabs/php_codesniffer:3.6 (lastest) support only PHPUnit:7.x as lastest.
And the whole magento-coding-standard depends on squizlabs/php_codesniffer' package.

Please, let me know if we have any variants here.
Thank you.

@ihor-sviziev
Copy link
Contributor

@korovitskyi, as an option, we can ask if they're going to add such compatibility and/or send them a pull request? :)

@korovitskyi
Copy link
Collaborator

@ihor-sviziev , yes, looks like they are going to add, we can see at PHP_CodeSniffer V 4.0, but it is not released yet.

@korovitskyi korovitskyi removed their assignment Aug 5, 2021
@m2-community-project m2-community-project bot moved this from Dev In Progress to Ready for Development in Platform Health Backlog Aug 5, 2021
@andrewbess andrewbess self-assigned this Aug 19, 2021
@m2-assistant
Copy link

m2-assistant bot commented Aug 19, 2021

Hi @andrewbess. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Project: Platform Health
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants