Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Update AddDataForIndia.php #33698

Closed
5 tasks
m2-assistant bot opened this issue Aug 6, 2021 · 7 comments · Fixed by #33172
Closed
5 tasks

[Issue] Update AddDataForIndia.php #33698

m2-assistant bot opened this issue Aug 6, 2021 · 7 comments · Fixed by #33172
Assignees
Labels
Area: Framework Component: Directory Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented Aug 6, 2021

This issue is automatically created based on existing pull request: #33172: Update AddDataForIndia.php


Description (*)

Admin Section

  1. On Add/Update Address page from Customer Information >> Address section
  2. Edit the Billing and Shipping Address from the Order view page
  3. Also in all the above sections, Ladakh is not coming under country India

Before: ✖️ Ladakh was not getting display in State dropdown

image

image

image

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: Directory Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Aug 6, 2021
@m2-assistant m2-assistant bot mentioned this issue Aug 6, 2021
6 tasks
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Aug 6, 2021
@engcom-Charlie engcom-Charlie added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Aug 6, 2021
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Charlie
Thank you for verifying the issue. Based on the provided information internal tickets MC-43011 were created

Issue Available: @engcom-Charlie, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog Aug 27, 2021
@ihor-sviziev ihor-sviziev reopened this Aug 31, 2021
@m2-community-project m2-community-project bot removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Progress: done labels Aug 31, 2021
@m2-community-project m2-community-project bot moved this from Done to Dev In Progress in High Priority Backlog Aug 31, 2021
@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Aug 31, 2021

According to the #33172 (comment), changes were reverted in the 2.4-develop branch. so I re-opened this issue.

@sdzhepa sdzhepa removed the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Oct 12, 2021
@m2-community-project m2-community-project bot added this to Ready for Confirmation in Issue Confirmation and Triage Board Oct 12, 2021
@m2-community-project m2-community-project bot removed this from Dev In Progress in High Priority Backlog Oct 12, 2021
@sdzhepa
Copy link
Contributor

sdzhepa commented Oct 12, 2021

Issue needs to be re-verified and description must be updated
#33172 (comment)

@engcom-Hotel engcom-Hotel self-assigned this Oct 13, 2021
@m2-assistant
Copy link
Author

m2-assistant bot commented Oct 13, 2021

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Hotel engcom-Hotel added Reported on 2.4.x Indicates original Magento version for the Issue report. Area: Framework labels Oct 13, 2021
@engcom-Hotel engcom-Hotel added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Oct 13, 2021
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Oct 13, 2021
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-1477 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Oct 13, 2021

✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Hotel
Copy link
Contributor

Hence the issue is still reproducible in Magento 2.4-develop, so confirming the issue. And also updated the description.

@engcom-Alfa engcom-Alfa added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Oct 19, 2021
@m2-community-project m2-community-project bot added this to Dev In Progress in High Priority Backlog Oct 19, 2021
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog Apr 6, 2022
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Dev In Progress in High Priority Backlog Oct 3, 2023
@github-jira-sync-bot github-jira-sync-bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: dev in progress labels Oct 3, 2023
@m2-community-project m2-community-project bot moved this from Dev In Progress to Done in High Priority Backlog Dec 1, 2023
@m2-community-project m2-community-project bot removed Progress: PR Created Indicates that Pull Request has been created to fix issue Progress: PR in progress labels Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Framework Component: Directory Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

Successfully merging a pull request may close this issue.

8 participants