Update AddDataForIndia.php

[manavluhar]

Added Ladakh Union Territory, Reference: https://en.wikipedia.org/wiki/Ladakh

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Update AddDataForIndia.php #33698: Update AddDataForIndia.php

[m2-assistant]

Hi @manavluhar. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[manavluhar]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[magento-engcom-team]

Hi @danielrussob, thank you for the review.
ENGCOM-9164 has been created to process this Pull Request
✳️ @danielrussob, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[magento-engcom-team]

Hi @aleron75, thank you for the review.
ENGCOM-9164 has been created to process this Pull Request
✳️ @aleron75, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Charlie]

✔️ QA Passed

Tested this PR with multiple scenarios. Checked for Ladakh option in State dropdown for India country in below sections.

Manual testing scenario:

Store front

1. Create an Account
2. My Account >> Address Book : Tried to update the Default billing and shipping address
3. On Shipping Address page after click on Proceed to checkout with guest customer
4. On Add new address section
5. Also in all above sections, tested that Ladakh is not coming under any other country than India

Back Office/Admin Section

1. On Add/Update Address page from Customer Information >> Address section
2. Edit the Billing and Shipping Address from Order view page
3. Add New Tax Rate Section
4. Also in all above sections, tested that Ladakh is not coming under any other country than India

Before: ✖️ Ladakh was getting display in State dropdown

After: ✔️ Ladakh is getting displayed in State dropdown for Country India.

Tested for other country

[ihor-sviziev]

Hi @manavluhar,
This change won't work for upgraded Magento instances. Could you create a new data upgrade script instead?

[m2-assistant]

Hi @manavluhar, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[ihor-sviziev]

@gabrieldagama @sidolov, there were changes requested… but then the Pr was merged… :(

[xmav]

@manavluhar Please be aware that original implementation is reverted as it cause issue in upgrade. This was noted before by @ihor-sviziev and confirmed by failed DB compare test.
Please implement in another way.

[ihor-sviziev]

@xmav, thx for the update