-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration tests failing during Magento setup #33802
Comments
Hi @sergeynezbritskiy. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. Please, add a comment to assign the issue:
🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Additional information regarding this issue:
|
During the investigation I've found few issues:
When object manager first creates ResourceCollection object, it has a dependency DeploymentConfig $deploymentConfig with
And this object is cached, but then I see that another instances of ResourceConnection is created with another instance of deploymentConfig as its dependency. The data of this new deploymentConfig get updated multiple times during installation, but when we go to the step "Disable maintenance mode" I see that at some place there is a call to the old object of resource connection with an old instance of deployment config. And when we try to get db connection, there is no info about db connection in the old version of deployment config.
I see 3 possible solutions:
I think that the third solution is preferable in this case, but think that someone from Adobe team need to approve this solution, no ? |
Hi @engcom-Hotel. Thank you for working on this issue.
|
Hi @engcom-Echo. Thank you for working on this issue.
|
Hi @sergeynezbritskiy |
@engcom-Echo, please double-check on 2.4.3, as this release wasn't yet merged to the 2.4-develop branch, or we can wait and then re-check again after merging. |
I can confirm that this issue exists. I just updated to magento 2.4.3 and then tried to run integration tests. I get the exact same error as @sergeynezbritskiy stated in the issue. The same bug also appears when trying to install magento with the file
I think that these errors are related as the setup process for integration tests tries to install magento with an env.php and config.php present, so I think both errors are fixable at once. Should I still create an extra issue for it or not, what do you think @ihor-sviziev? |
No need to create a separate issue. I reopened this one |
✅ Jira issue https://jira.corp.magento.com/browse/AC-1405 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-Alfa. Thank you for verifying the issue. |
We are struggling with the same issue, and i can confirm that the PR #33803 fixes it. |
i too can confirm, that the PR #33803 fixes the issue. |
For a reason I do not have time to investigate for, I have removed the package
Maybe it will help someone! |
Any updates on this issue? I can reproduce it in a pipeline on Magento 2.4.4. |
I also confirm that #33803 fixes the issue with installation in pipelines in our case |
Any updates on this issue? I can reproduce it in a pipeline on Magento 2.4.4. |
Hello @pawan-mittal, The related PR #33803 is in Thanks |
Reproduced on 2.4.5 |
Does anybody by chance already have a patch file to fix this? |
Here's one for Magento 2.4.5 which I've created earlier today, it's based on #33803 but had to fix some merge conflicts, so hopefully those were solved correctly, but it seems to work on our end at least. |
@hostep , thanks a lot, awesome. Works fine for me. |
Reproduced on 2.4.5-p1. The patch provided by @hostep works. |
The current pull request here does not work on 2.4.3 currently since the load() function differs between 2.4.3 and 2.4.4; |
FWIW i've just got this on 2.4.7-beta1 My CI tooling can fix it by re-running |
This problem has indeed returned in 2.4.7-beta1, but also in 2.4.6-p2 (which is now available in pre-release and will be available from the 8th of August for everyone). I've opened a new issue for this: #37805 |
Preconditions (*)
Steps to reproduce (*)
composer create-project --repository-url=https://repo.magento.com/ magento/project-community-edition
bin/magento module:enable --all
update the configuration in
dev/tests/integration/etc/install-config-mysql.php` (no RabbitMQ configuration)mysql -e "DROP DATABASE IF EXISTS magento_integration_tests"
mysql -e "CREATE DATABASE magento_integration_tests"
cd dev/tests/integration && php ../../../vendor/bin/phpunit
Expected result (*)
dev/tests/integration/phpunit.xml.dist
should start runningActual result (*)
Log file is attached below
Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.
log.txt
The text was updated successfully, but these errors were encountered: