Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currency issue in Product details and Shopping cart page for base currency other than USD / EURO #34003

Open
onlinebizsoft opened this issue Sep 6, 2021 · 63 comments
Labels
Area: Pricing Component: CurrencySymbol Component: Pricing Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for grooming Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@onlinebizsoft
Copy link

onlinebizsoft commented Sep 6, 2021

  1. Use base currency as GBP for example
  2. Use Display currency as USD or MAD for example (store currency and base currency must be very different to see the issue)
  3. Setup a few custom options (customizable options) with additional prices (do not test with configurable product) 

Steps to reproduce

  1. Use base currency as GBP(Stores-Configuration-General-Currency Setup).
  2. Use Display currency as USD.
  3. Save the config and clear cache
  4. View the Product on front end
  5. View Shopping Cart page

Expected result (*)

The Currency should be displayed with USD for a product as per Configuration

Note:

If we use Base currency as EUR and Display currency as USD we have a option for changing currency on the right corner in frontend.

Actual result (*)

There is a difference in Currency symbol for a Product. It is displayed with currency GBP(British Pound).

If we use Base currency as GBP and Display currency as USD or MAD we miss that option for changing currency on the right corner in frontend. Tested with other Currency Configurations.

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • < > Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • < > Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • < > Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • < > Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Sep 6, 2021

Hi @onlinebizsoft. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@onlinebizsoft
Copy link
Author

I think there are different problem in different user cases, I can see there were some question or patch from the community for different cases
https://github.com/magesuite/magento-patches/blob/master/optional/m24-fix-different-price-in-cart-vs-on-pdp.patch
https://community.magento.com/t5/Magento-1-x-Programming/Custom-Option-Price-calculated-wrong/td-p/7033

@onlinebizsoft
Copy link
Author

@engcom-Hotel

@engcom-Delta engcom-Delta self-assigned this Sep 7, 2021
@m2-assistant
Copy link

m2-assistant bot commented Sep 7, 2021

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Delta
Copy link
Contributor

Hi @onlinebizsoft ,
I tried in reproducing the issue on Magento 2.4 Develop. i could see that price of the product is same in Product view page & cart ,price is same everywhere.
Kindly find the attached screenshots for reference.
Product_page
Euro_dollar
US_Dollar

It would be great if you can provide what are the base price you had customized so that we can replicate it.
Hence added 'Needs Update' label.

@engcom-Delta engcom-Delta added Issue: needs update Additional information is require, waiting for response and removed Issue: ready for confirmation labels Sep 7, 2021
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Sep 7, 2021
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Sep 7, 2021
@onlinebizsoft
Copy link
Author

@engcom-Delta what additional price are you testing for custom option "L" and "Yellow" ? Is it customizable option or configurable product?

@onlinebizsoft
Copy link
Author

@engcom-Delta I believe that you didn't look at "pre-conditions" at all, I wrote clearly that you need to test with customizable options and make sure that these customizable options have additional prices.

You could imagine the case you sell custom made product (phone cases for example), you don't have any item in stock, your products has options like made by leather, gold, may add some diamond stones,....etc so these products setup would be using custom options and having additional prices.

@onlinebizsoft
Copy link
Author

The issue is very clear and it is quite bad, I think not many people are using customizable option with additional price so no one raised it. Can you please confirm the issue again @engcom-Delta @engcom-November ?

@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Oct 4, 2021

@onlinebizsoft, the options in the custom options are saying +$N, and it's not changing the final price on the product page when you're selecting an option, so it's basically ok behavior (not the best one, but not so terrible).

@onlinebizsoft
Copy link
Author

@ihor-sviziev I agree with the way it calcuate the price on the preview product view but you see we cant have different price between 2 places.
Customer see 1 price then they add to cart and see another price!
So the most possible solution might be having the price calcuated in the same way on cart? So we convert currency for base price, custom option price,....first.

@engcom-Delta
Copy link
Contributor

Hi @onlinebizsoft,
We could find out that issue with Euro currency only but it works fine for Dollar Currency .
Hence added the label 'Issue Confirmed'.
Please find the attached screen shots for reference.
Dollor_currency_NODifference
Euro_currency_Difference

@engcom-Delta engcom-Delta added Area: Pricing Component: Pricing and removed Issue: needs update Additional information is require, waiting for response labels Oct 27, 2021
@m2-community-project m2-community-project bot moved this from Needs Update to Ready for Confirmation in Issue Confirmation and Triage Board Oct 27, 2021
@engcom-Delta engcom-Delta added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch and removed Issue: ready for confirmation labels Oct 27, 2021
@engcom-Delta engcom-Delta added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: ready for confirmation labels Oct 27, 2021
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Oct 27, 2021
@engcom-November engcom-November removed their assignment Jan 25, 2023
@m2-community-project m2-community-project bot moved this from Dev In Progress to Ready for Development in High Priority Backlog Jan 25, 2023
@engcom-Alfa engcom-Alfa self-assigned this Feb 10, 2023
@m2-assistant
Copy link

m2-assistant bot commented Feb 10, 2023

Hi @engcom-Alfa. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog Feb 10, 2023
@magento magento deleted a comment from magento-deployment-service bot Feb 10, 2023
@magento magento deleted a comment from magento-deployment-service bot Feb 10, 2023
@engcom-Alfa
Copy link
Contributor

Hi @onlinebizsoft

This issue is happening because of the known limitations of the Adobe Commerce platform related to price calculation rounding precision.

The issue will be fixed in the scope of the Epic https://jira.corp.adobe.com/browse/AC-6221

We will keep posted here about the progress on the above JIRA - AC-6221.
hence updating label as confirmed.

Thanks

@engcom-Alfa engcom-Alfa added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Feb 13, 2023
@github-jira-sync-bot
Copy link

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

@github-jira-sync-bot github-jira-sync-bot removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Feb 13, 2023
@engcom-Alfa engcom-Alfa added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Feb 13, 2023
@github-jira-sync-bot github-jira-sync-bot removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Feb 13, 2023
@github-jira-sync-bot
Copy link

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

@engcom-Alfa engcom-Alfa added the Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch label Feb 13, 2023
@engcom-Alfa engcom-Alfa removed their assignment Feb 13, 2023
@m2-community-project m2-community-project bot moved this from Dev In Progress to Ready for Development in High Priority Backlog Feb 13, 2023
@engcom-Alfa engcom-Alfa added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Feb 13, 2023
@github-jira-sync-bot
Copy link

❌ Cannot export the issue. This GitHub issue is already linked to Jira issue(s): https://jira.corp.adobe.com/browse/AC-1558

@github-jira-sync-bot github-jira-sync-bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. and removed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. labels Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Pricing Component: CurrencySymbol Component: Pricing Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for grooming Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
High Priority Backlog
  
Ready for Development
Development

No branches or pull requests

9 participants