Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Fix accessibility errors on cart and checkout pages #34483

Closed
2 of 5 tasks
m2-assistant bot opened this issue Oct 29, 2021 · 3 comments · Fixed by #33851
Closed
2 of 5 tasks

[Issue] Fix accessibility errors on cart and checkout pages #34483

m2-assistant bot opened this issue Oct 29, 2021 · 3 comments · Fixed by #33851
Assignees
@vovayatsyuk
Labels
Area: UI Framework Component: Checkout Component: GiftMessage Component: Ui Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented Oct 29, 2021

This issue is automatically created based on existing pull request: #33851: Fix accessibility errors on cart and checkout pages

Description (*)

This PR fixes Accessibility errors reported by Lighthouse module (Available in Chrome dev tools) on the shopping cart and checkout pages.

Manual testing scenarios (*)

  1. Open Stores > Configuration > Sales > Sales > Gift Options and enable gift messages for both orders and per item levels.
  2. Add product to the cart.
  3. Navigate to the shopping cart page and run the Lighthouse accessibility test. There is an "ARIA IDs are not unique" error.
  4. Navigate to the checkout page and run the Lighthouse accessibility test. There are navigation and ARIA errors.
  5. Apply the patch and check the pages again.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: Checkout Component: GiftMessage Component: Ui Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. labels Oct 29, 2021
@m2-assistant m2-assistant bot mentioned this issue Oct 29, 2021
Merged
6 tasks
@engcom-Alfa engcom-Alfa added Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: UI Framework Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Oct 29, 2021
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-1589 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Oct 29, 2021

✅ Confirmed by @engcom-Alfa. Thank you for verifying the issue.
Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@sidolov sidolov added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Nov 5, 2021
@sidolov
Copy link
Contributor

sidolov commented Nov 5, 2021

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #33851 by @vovayatsyuk in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming release.

@sidolov sidolov closed this as completed Nov 5, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vovayatsyuk vovayatsyuk

Labels
Area: UI Framework Component: Checkout Component: GiftMessage Component: Ui Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
High Priority Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix accessibility errors on cart and checkout pages vovayatsyuk/magento2
4 participants
@vovayatsyuk @sidolov @engcom-Alfa @github-jira-sync-bot