Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Integration Tests to be compatible with PHP 8.1 #34567

Closed
andrewbess opened this issue Nov 8, 2021 · 3 comments
Closed

Fix Integration Tests to be compatible with PHP 8.1 #34567

andrewbess opened this issue Nov 8, 2021 · 3 comments
Assignees
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Project: Platform Health

Comments

@andrewbess
Copy link
Contributor

andrewbess commented Nov 8, 2021

Description (*)

We run builds on PHP 8.1 and have results provided below:

  • Failed 298
  • Broken 1672
  • Passed 9915
  • Skipped 179

We need to fix all failed and broken tests.

Related issue (*)

@andrewbess andrewbess added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Project: Platform Health labels Nov 8, 2021
@andrewbess andrewbess self-assigned this Nov 8, 2021
@m2-assistant
Copy link

m2-assistant bot commented Nov 8, 2021

Hi @andrewbess. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added this to Dev In Progress in Platform Health Backlog Nov 8, 2021
@m2-assistant
Copy link

m2-assistant bot commented Nov 8, 2021

Hi @andrewbess. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@andrewbess andrewbess changed the title [EPIC] Fix Integration Tests to be compatible with PHP 8.1 Fix Integration Tests to be compatible with PHP 8.1 Nov 9, 2021
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in Platform Health Backlog Dec 8, 2021
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in Platform Health Backlog Dec 9, 2021
@andrewbess andrewbess reopened this Dec 9, 2021
@m2-community-project m2-community-project bot moved this from Done to Pull Request In Progress in Platform Health Backlog Dec 9, 2021
@andrewbess andrewbess moved this from Pull Request In Progress to Dev In Progress in Platform Health Backlog Dec 9, 2021
@m2-community-project m2-community-project bot moved this from Dev In Progress to Done in Platform Health Backlog Dec 10, 2021
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in Platform Health Backlog Dec 15, 2021
@andrewbess andrewbess reopened this Dec 15, 2021
@m2-community-project m2-community-project bot moved this from Done to Pull Request In Progress in Platform Health Backlog Dec 15, 2021
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in Platform Health Backlog Dec 18, 2021
@andrewbess andrewbess reopened this Dec 19, 2021
@m2-community-project m2-community-project bot moved this from Done to Dev In Progress in Platform Health Backlog Dec 19, 2021
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in Platform Health Backlog Dec 19, 2021
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Dev In Progress in Platform Health Backlog Dec 20, 2021
@andrewbess
Copy link
Contributor Author

Closed due to fixes have been delivered into 2.4-develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Project: Platform Health
Projects
No open projects
Development

No branches or pull requests

3 participants