New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed php 8.1 deprecations to pass Integration Tests #34774
Fixed php 8.1 deprecations to pass Integration Tests #34774
Conversation
Hi @anzin. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review. For more details, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @anzin
Thank you for your contribution
Please check my comment
Thank you in advance.
@@ -115,7 +115,7 @@ public function getTreeLoaderUrl() | |||
|
|||
$currentTreePath = $this->getRequest()->getParam('current_tree_path'); | |||
|
|||
if (strlen($currentTreePath)) { | |||
if ($currentTreePath && strlen($currentTreePath)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @anzin
I think we need to check $currentTreePath
on null, because '0' in condition is false.
if ($currentTreePath && strlen($currentTreePath)) { | |
if ($currentTreePath !== null && strlen($currentTreePath)) { |
@magento run Static Tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Static Tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @anzin
Thank you for your contribution
Approved ✔️
Hi @andrewbess, thank you for the review.
|
pending delivery https://github.com/magento-commerce/magento2ce/pull/7295 |
Description (*)
Fixed deprecations function php 8.1 to pass Integration Tests
Related Pull Requests
Related Issues (if relevant)
Contribution checklist (*)