Virtual refunded orders do not persist closed state when comment is added via Admin

[ksenia-zlotin]

I believe this is caused by the commit here:
4f90cf5
I would like an explanation why was this check added and how come even on a clean 2.4.3-p1 copy I am able to recreate this error?

Preconditions (*)

1. Magento 2.4.3-p1
2. PHP 7.4.13

Steps to reproduce (*)

1. Install clean copy of Magento 2.4.3-p1 without sample data
2. Create virtual product with a price of $10
3. Place order with that product and invoice it in the Admin so that credit memo is possible
4. Press the credit memo button and go ahead and create one
5. In the

order view loaded after the creditmemo saved, scroll to bottom of page where comments section status dropdown is

Expected result (*)

1. The status dropdown should only show the 'Closed' option, that way when a comment is added to this closed order - it does not set it to 'Complete'.

Actual result (*)

1. order state is never set to closed when the refund saves successfully, while the status does update to closed in the db
2. order status dropdown in comments section showing only 'Complete' option which will cause any new comment which will be added to revert the order status from 'Closed' to 'Complete'

• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.

[m2-assistant]

Hi @ksenia-zlotin. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @engcom-November, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

[engcom-November]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @engcom-November, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

[engcom-November]

Verified the issue on Magento 2.4-develop branch and is reproducible. As per Magento docs, order status should be closed after issuing credit memo and customer is refunded.
For Virtual Product, Order status is displayed "Complete" in drop-down but displayed "Closed" in comment. On adding new comment, its displayed as Complete in comment section as well.

Simple Product behavior:

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.magento.com/browse/AC-2811 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[Usik2203]

@magento I am working on this

[engcom-Hotel]

Hello @ksenia-zlotin,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-2811 by the internal team
Related commits: https://github.com/magento/magento2/search?q=AC-2811&type=commits

Based on the Jira ticket, the target version is 2.4.6.

Thanks