i18n:collect-phrases does not include mail template translations in depend constructs

[norgeindian]

Preconditions (*)

1. Magento 2.4.3-p2

Steps to reproduce (*)

1. Run bin/magento i18n:collect-phrases --output=test.csv vendor/magento/module-sales/view/frontend/email/
2. Take a look at vendor/magento/module-sales/view/frontend/email/order_new.html and see for example the following code snippet: {{depend store_hours}} {{trans 'Our hours are <span class="no-link">%store_hours</span>.' store_hours=$store_hours |raw}} {{/depend}}

Expected result (*)

1. I would expect, that all string, which shall be translated, are included in my test file.

Actual result (*)

1. Strings, which are surrounded by a depend construct, are not included in the exported file. So for example Our hours are <span class="no-link">%store_hours</span>. is not included in the file.

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• [ x] Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @norgeindian. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Delta]

Hi @norgeindian ,
We tried to reproduce the issue on Magento 2.4 develop instance , issue is reproducible. Hence issue has been confirmed.

Steps followed:

1. Run bin/magento i18n:collect-phrases --output=test.csv app/code/magento/sales/view/frontend/email/

2. Take a look at app/code/magento/sales/view/frontend/email/order_new.html and see for example the following code snippet: {{depend store_hours}} {{trans 'Our hours are %store_hours.' store_hours=$store_hours |raw}} {{/depend}}

Actual results:

Strings, which are surrounded by a depend construct, are not included in the exported file. So for example Our hours are %store_hours. is not included in the file.

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.magento.com/browse/AC-3499 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[sprankhub]

@magento I am working on this

[glo71317]

@sprankhub thanks for contributing, Internal team is processing your PR along with your commits and will fix failed automation tests.

[engcom-Hotel]

Hello,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-3499 by the internal team
Related commits: https://github.com/magento/magento2/search?q=AC-3499&type=commits

Based on the Jira ticket, the target version is 2.4.6.

Thanks