Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process trans Directives Nested in depend / if Directives #35640

Merged
merged 3 commits into from
Sep 9, 2022
Merged

Process trans Directives Nested in depend / if Directives #35640

merged 3 commits into from
Sep 9, 2022

Conversation

sprankhub
Copy link
Member

Description (*)

This PR makes sure that trans directives, which are nested in depend or if directives are handled correctly. Currently, the i18n:collect-phrases command would not catch the phrases, so that they are not added to the translation file.

Related Pull Requests

n/a

Fixed Issues (if relevant)

  1. Fixes i18n:collect-phrases does not include mail template translations in depend constructs #35449

Manual testing scenarios (*)

See fixed issue #35449.

Questions or comments

n/a

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 18, 2022

Hi @sprankhub. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Jun 18, 2022
@m2-community-project m2-community-project bot added this to Pending Review in Pull Requests Dashboard Jun 18, 2022
@sprankhub
Copy link
Member Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@sprankhub
Copy link
Member Author

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@sprankhub
Copy link
Member Author

Failing test should be completely unrelated to the changes.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit ca71b88 into magento:2.4-develop Sep 9, 2022
@sprankhub sprankhub deleted the 35449-fix-i18n-collect-phrases-command branch September 9, 2022 14:03
@andrewbess
Copy link
Contributor

This PR already merged and shouldn't have pending review status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P3 May be fixed according to the position in the backlog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i18n:collect-phrases does not include mail template translations in depend constructs
3 participants