-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process trans Directives Nested in depend / if Directives #35640
Process trans Directives Nested in depend / if Directives #35640
Conversation
Hi @sprankhub. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review. For more details, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Failing test should be completely unrelated to the changes. |
This PR already merged and shouldn't have pending review status |
Description (*)
This PR makes sure that
trans
directives, which are nested independ
orif
directives are handled correctly. Currently, thei18n:collect-phrases
command would not catch the phrases, so that they are not added to the translation file.Related Pull Requests
n/a
Fixed Issues (if relevant)
Manual testing scenarios (*)
See fixed issue #35449.
Questions or comments
n/a
Contribution checklist (*)