Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Support the use of PHP 8.0 "mixed" type #35579

Closed
m2-assistant bot opened this issue Jun 6, 2022 · 2 comments · Fixed by #35572
Closed

[Issue] Support the use of PHP 8.0 "mixed" type #35579

m2-assistant bot opened this issue Jun 6, 2022 · 2 comments · Fixed by #35572
Assignees
@pmzandbergen
Labels
Area: Framework Component: Module Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.4 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
High Priority Backlog

Comments

@m2-assistant
Copy link

m2-assistant bot commented Jun 6, 2022

This issue is automatically created based on existing pull request: #35572: Support the use of PHP 8.0 "mixed" type

Currently Magento does not compile when using the mixed type, neither as a parameter or return type. The generated Interceptor / Proxy / etc. classes try to make this union type nullable (?mixed). This will result in a fatal PHP error since the union type already includes null, and null is not nullable.

During compilation you will be encountered with the following error: Type "mixed" cannot be nullable

This patch checks if the type is mixed before adding the nullable (?) prefix.
@m2-assistant m2-assistant bot added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels Jun 6, 2022
@m2-assistant m2-assistant bot mentioned this issue Jun 6, 2022
Merged
1 task
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Jun 6, 2022
@engcom-Lima engcom-Lima added Component: Module Area: Framework Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reported on 2.4.4 Indicates original Magento version for the Issue report. Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Aug 25, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-6545 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Aug 25, 2022

✅ Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmzandbergen pmzandbergen

Labels
Area: Framework Component: Module Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.4 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
High Priority Backlog
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support the use of PHP 8.0 "mixed" type pmzandbergen/magento2
3 participants
@pmzandbergen @engcom-Lima @github-jira-sync-bot