Support the use of PHP 8.0 "mixed" type #35572

pmzandbergen · 2022-06-02T14:03:04Z

Currently Magento does not compile when using the mixed type, neither as a parameter or return type. The generated Interceptor / Proxy / etc. classes try to make this union type nullable (?mixed). This will result in a fatal PHP error since the union type already includes null, and null is not nullable.

During compilation you will be encountered with the following error: Type "mixed" cannot be nullable

This patch checks if the type is mixed before adding the nullable (?) prefix.

Resolved issues:

resolves [Issue] Support the use of PHP 8.0 "mixed" type #35579: Support the use of PHP 8.0 "mixed" type

The PHP "mixed" type is a union type including null, see: https://www.php.net/manual/en/language.types.declarations.php#language.types.declarations.mixed Therefore the type is never nullable, e.g. `?mixed $someParameter` is invalid and will generate a Fatal PHP Error: "Mixed types cannot be nullable, null is already part of the mixed type." This commit will fix mixed parameters.

m2-assistant · 2022-06-02T14:03:07Z

Hi @pmzandbergen. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

xmav · 2022-06-02T17:21:08Z

Hi @pmzandbergen !
Could you please share your use case/code snipped to reproduce this issue ?

Thanks,
Maksym

pmzandbergen · 2022-06-03T06:06:52Z

Hi @pmzandbergen ! Could you please share your use case/code snipped to reproduce this issue ?

Thanks, Maksym

Created a very simple example module @ https://github.com/pmzandbergen/some-module

Simply add it to a vanilla Magento 2.4.4 installation and run bin/magento setup:di:compile. Output:

% bin/magento setup:di:compile                        
Compilation was started.
Interceptors generation... 4/9 [============>---------------]  44% 4 secs 218.0 MiB
In Generator.php line 140:
                                                                                                                                                                                                                
  Type "mixed" cannot be nullable                                                                                                                                                                               
  Class Some\Module\Model\TestClass\Interceptor generation error: The requested class did not generate properly, because the 'generated' directory permission is read-only. If --- after running the 'bin/mage  
  nto setup:di:compile' CLI command when the 'generated' directory permission is set to write --- the requested class did not generate properly, then you must add the generated class object to the signature  
   of the related construct method, only.                                                                                                                                                                       
                                                                                                                                                                                                                

setup:di:compile

This is caused by Magento using ?mixed as a parameter type for the Interceptor for Some\Module\Model\TestClass

ihor-sviziev · 2022-06-06T08:35:39Z

Hi @pmzandbergen,
Could you please cover your changes with integration tests?

ihor-sviziev · 2022-06-06T08:42:30Z

@magento run all tests
@magento create issue

magento-automated-testing · 2022-06-06T08:42:39Z