-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monolog issue #35604
Comments
Hi @Nuranto. Thank you for your report.
Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:
For more details, review the Magento Contributor Assistant documentation. Add a comment to assign the issue: To learn more about issue processing workflow, refer to the Code Contributions.
🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
i think we should report here |
Similar to this #35596 which affects integration tests |
Hi @engcom-November. Thank you for working on this issue.
|
Hi @Nuranto ,
|
you need install monolog v2.7.0 to able see problem |
Thanks for the update @mrtuvn |
The facts
Either way there is an action for magento here, when you build a version of latest magento from scratch you will pull in a monolog version incompatible with some magento code. The maintainer of monolog thinks the implementations by magento in the data migration tool and the integration test infrastructure is, and i quote, "madness". See Seldaek/monolog#1684 (comment) and also see #35596 (comment) where this issue affects the ability to run tests, the thing that ensures we are able to deliver robust software. |
Verified the issue again by installing Magento 2.4.4 project-community-edition with PHP 8.1 but could not able to reproduce the issue with below steps performed:
|
@engcom-November this issue i think you may also need to install https://github.com/magento/data-migration-tool#install-the-data-migration-tool For my PR (#35596) to replicate you would need to run the integration tests but best to keep separate as they'd be separate codefixes :) |
Verified the issue again on Magento 2.4.4 Project community edition with PHP 8.1.6 and the issue is reproducible on installing data-migration-tool. |
✅ Jira issue https://jira.corp.magento.com/browse/AC-5973 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-November. Thank you for verifying the issue. |
Also reproducible when you run integration tests. |
Updating to use a handler seems like the right thing to do. |
Just a notification that a further update to Monolog versions occurred ~3 hours ago - I had code like: composer require monolog/monolog:"!=2.7.0" --no-update Which I now changed to: composer require monolog/monolog:"<2.7.0" --no-update |
See magento/magento2#35604 Looks like this is a wontfix.
See magento/magento2#35604 Looks like this is a wontfix.
Looks like in Magento 2.4.5 we have a fix for this issue 360fd1b |
The full AC-3556 fix is here: b2bfd05 Unfortunately the fix seems just like a workaround, because this problem might happen again in the future. |
Agreed @hostep I did try and have some conversation about this back in June but was ignored. My workaround was then taken in any case 🙃 |
Hi there, I think you missed this one : |
Hello, As I can see this issue got fixed by the internal team Hence closing the issue. Thanks |
Preconditions and environment
Steps to reproduce
Expected result
Everything works fine
Actual result
Additional information
Monolog 2.7.0 has bee released yesterday, and have breaking changes.
Quick Solution : fix dependency to 2.6.0
Best Solution : fix compatibility issues
Note that everyone who upgrades to 2.4.4 from now will probably have this issue.
Quick solution for devs who don't want to wait for a fix & release :
composer require monolog/monolog:2.6.0
Release note
No response
Triage and priority
The text was updated successfully, but these errors were encountered: