Replace 'PayPal Account' translation in token_list.phtml

[Morerice]

Summary (*)

In the Stored Payment Methods page, there are 2 sections, one to render the card tokens and the other to render the account tokens. However, the table header for the accounts section is titled PayPal Account. This is fine if only paypal account tokens are to be created.

Examples (*)

token_list.phtml:

<?php if (count($tokens) !== 0) : ?>
    <div class="table-wrapper my-credit-cards">
        <table class="data table table-credit-cards" id="token-list-table">
            <thead>
            <tr>
                <th scope="col" class="col"><?= $block->escapeHtml(__('PayPal Account')) ?></th>
                <th scope="col" class="col actions">&nbsp;</th>
            </tr>
            </thead>
            <tbody>
            <?php foreach ($tokens as $token) : ?>
                <?= /* @noEscape */ $block->renderTokenHtml($token) ?>
            <?php endforeach; ?>
            </tbody>
        </table>
    </div>
<?php endif; ?>

Proposed solution

However we are currently working on functionality to add other tokenizable account payment methods (such as GooglePay). Hence, since this section represents all tokens with type=Account we think it would be more representative if the section was titled Account instead of PayPal Account.

If we can get some confirmation for this, we can also submit a PR ourselves for it.

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users with no workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @Morerice. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @engcom-Echo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
     Details

     If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
     Details

     - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
     - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
     - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Echo]

Hello @Morerice,

Thanks for the report and collaboration!

I have enabled the Braintree in which I have enabled Google Pay. But as we know that we don't have VAULT feature to enable it.
Hence it is not coming in the Stored Payment Method.
Please find the attached screen for your reference.

Steps for reproduce

1. Install fresh Magento setup
2. Configure Braintree with Paypal
3. Create Category and Product
4. Purchase one Product with Braintree
5. Go to MyAccount on frontend
6. Check stored Payment Methods Sections

Please provide more information for the payment method which we can see in the stored payment method sections so that we can reproduce this.

Thanks

[Morerice]

Hi @engcom-Echo,

Thanks for your response. My request wasn't related to the Braintree module. We at Adyen have our Magento Module created to process payments. We are looking into using Magento Vault to store token details of payment methods that are not cards.

Hence, when these payment methods are stored in the vault_payment_token table with type=account, they will then be shown in the Stored Payment Methods section on the customer's account.

The issue is that since these payment methods may have different types apart from paypal (ideal, SEPA, Sofort etc.) it wouldn't make sense to have these tokens in a table where the header is PayPal Account. That's why we think it would make more sense to rename the header to Account to make it more generic.

Feel free to get back to me if the issue is still not clear enough.

Thanks,
Jean
Adyen

[engcom-Echo]

Hello @Morerice,

Thanks for you response.

As per our discussion we are understanding the issue is that in future if we adds new different payment method with Vault feature then this payment method will come under the Stored Payment Method sections and then the table name Account in place of PayPal Account have make more sense.

Hence we are taking this as feature request.

Thanks

[Morerice]

Hi @engcom-Echo,

Thanks for the update. Since this seems to be quite a straight-forward label change, is it ok if I submit a pull request for it? Or do you have some structure that I have to follow for the Pull request to be accepted?

Thanks,
Jean
Adyen

[cjnewbs]

@Morerice I'm also working on another payment method that uses this. Last night I was trying to figure out how to have my module override the core translations but had no luck.

I think replacing with Stored Accounts would be ok? I'm happy to pick this up to get the ball rolling.

[engcom-November]

The Stored Payment Methods page uses the templete were table name is PayPal Account, if the user wants to use any other service with vault other then paypal, the table name will remain the same.
This shouldn't be the case, so we are reassigning this as a bug instead of feature request.

Thank you.

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-11852 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.