New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change header wording to apply to other payment providers, resolves #35622 #37959

Merged

magento-devops-reposync-svc merged 10 commits into magento:2.4-develop from cjnewbs:vault-accounts-header

May 28, 2024

Contributor

cjnewbs commented Sep 5, 2023 •

edited

Loading

Description (*)

In issue #35622 it has been identified that that the core template only refers to PayPal, however this functionality is being utilised by other payment providers. This PR changes the text and translations for PayPal Account to Account so that other providers can use this functionality without having to override the core template.

Related Pull Requests

N/A

Fixed Issues (if relevant)

Fixes magento/magento2#35622

Manual testing scenarios (*)

Log-in as a customer with payment accounts stored in the Magento_Vault module
The header that the token shows under should read Account instead of PayPal Account

Questions or comments

N/A

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
All automated tests passed successfully (all builds are green)


          Change header wording to apply to other payment providers, resolves m…

9f23275

…agento#35622

m2-assistant bot commented Sep 5, 2023

Hi @cjnewbs. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

m2-community-project bot added the Progress: pending review label

engcom-Hotel added the Priority: P3 label

Contributor Author

cjnewbs commented Sep 5, 2023

@magento run all tests

magento-automated-testing bot commented Sep 5, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

cjnewbs and others added 2 commits

September 6, 2023 09:51


          Resolve existing coding standards issue

6c90e83


          Merge branch '2.4-develop' into vault-accounts-header

0ccfbd7

Contributor Author

cjnewbs commented Sep 6, 2023

@magento run all tests

magento-automated-testing bot commented Sep 6, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

Contributor Author

cjnewbs commented Sep 6, 2023

@magento run Functional Tests CE

magento-automated-testing bot commented Sep 6, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

Contributor Author

cjnewbs commented Sep 6, 2023

@magento run Functional Tests EE

magento-automated-testing bot commented Sep 6, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

Contributor Author

cjnewbs commented Sep 6, 2023

@magento run Functional Tests B2B,Unit Tests,WebAPI Tests

magento-automated-testing bot commented Sep 6, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.


          Merge branch '2.4-develop' into vault-accounts-header

9b386fa

Contributor Author

cjnewbs commented Sep 6, 2023

@magento run all tests

magento-automated-testing bot commented Sep 6, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

Contributor Author

cjnewbs commented Sep 6, 2023

@magento run Functional Tests CE,WebAPI Tests,Sample Data Tests CE,Sample Data Tests EE,Sample Data Tests B2B

magento-automated-testing bot commented Sep 6, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

Contributor Author

cjnewbs commented Sep 6, 2023

@magento run Functional Tests CE

Dear God these tests are flaky

magento-automated-testing bot commented Sep 6, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

Contributor Author

cjnewbs commented Sep 7, 2023

@mgento run WebAPI Tests,Sample Data Tests CE,Sample Data Tests EE,Sample Data Tests B2B

Contributor Author

cjnewbs commented Sep 7, 2023

@magento run WebAPI Tests

magento-automated-testing bot commented Sep 7, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.


          Merge branch '2.4-develop' into vault-accounts-header

80eb0f3

Contributor Author

cjnewbs commented Sep 9, 2023

FFS.

@magento run all tests

magento-automated-testing bot commented Sep 9, 2023

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please message the #magento-devops slack channel if they don't show in a reasonable amount of time and a representative will look into any issues.

m2-community-project bot added Progress: ready for testing and removed Progress: extended testing labels

Contributor

engcom-November commented Apr 24, 2024 •

edited

Loading

Repeating Functional Tests are falky and are known issues, these are not related to PR changes.

Functional Tests B2B
1st run:

2nd run:

Known issues:
ACQE-6438 - StorefrontPropertiesOfAProductAttributeTest
ACQE-6350 - AdminCreateDraftQuoteFromQuoteGridPageWithMultipleStoresTest

Functional Tests CE
There are no repeating failures, and rest are flaky.
1st run:

2nd run:

Functional Tests EE
1st run:

2nd run:

Known issues:
ACQE-6438 - StorefrontPropertiesOfAProductAttributeTest
ACQE-6331 - StorefrontCreateOrderAllQuantityGroupedProductOptionDefaultStockTest

Hence moving this to Merge in progress.

m2-community-project bot added Progress: accept and removed Progress: ready for testing labels

Contributor

engcom-Charlie commented Apr 29, 2024

Hi @engcom-November, as per this comment, I can see that for B2B, B2b-2690 is repeatative failure and also CE, AC-6951 have failed in both successive builds so please check once again and provide more information on them. Till then moving it to Extended Testing.

m2-community-project bot added Progress: extended testing and removed Progress: accept labels


          Merge branch '2.4-develop' into vault-accounts-header

afafd16

Contributor

engcom-November commented Apr 29, 2024

@magento run all tests

m2-community-project bot added Progress: accept and removed Progress: extended testing labels

m2-community-project bot added Progress: extended testing and removed Progress: accept labels

Contributor

engcom-November commented Apr 30, 2024

@magento run WebAPI Tests

Contributor

engcom-November commented Apr 30, 2024

@engcom-Charlie, for B2B-2690 I have updated the comment with open jira, and CE, AC-6951 has passed in the latest run.
Hence moving it back to Merge in Progress.

m2-community-project bot added Progress: accept and removed Progress: extended testing labels

magento-devops-reposync-svc merged commit f6bb182 into magento:2.4-develop

9 of 12 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: P3 Progress: accept Project: Community Picked Triage: Dev.Experience