Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$request->getFullActionName() returns "__" on Homepage #35756

Open
5 tasks
MagePsycho opened this issue Jul 12, 2022 · 9 comments
Open
5 tasks

$request->getFullActionName() returns "__" on Homepage #35756

MagePsycho opened this issue Jul 12, 2022 · 9 comments
Assignees
Labels
Area: Framework Component: Ui Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: dev in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it

Comments

@MagePsycho
Copy link
Contributor

Preconditions and environment

  • Magento 2.4.4
  • FPC enabled
  • Observe the event controller_front_send_response_before

Steps to reproduce

  1. Observe the event controller_front_send_response_before on frontend area (etc/frontend/events.xml)
  2. Get the get full action name from the observer class as $fullActionName = $observer->getEvent()->getRequest()->getFullActionName()
public function execute(Observer $observer)
{
    $request = $observer->getEvent()->getRequest();
    $fullActionName = $request->getFullActionName();
    file_put_contents(BP . '/var/log/http.log', $fullActionName . PHP_EOL, FILE_APPEND | LOCK_EX);
    // $fullActionName gives __ value 
    // ...    
}
  1. Reload the homepage for one more time (to make sure the page is cached now). If FPC is disabled, make sure to enable it.
  2. Now load the homepage and check the value of $fullActionName. It will always return __ (Please refer to the attached screenshot)
    image

Expected result

$fullActionName should give cms_index_index

Actual result

$fullActionName is giving __

Additional information

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Jul 12, 2022

Hi @MagePsycho. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added this to Ready for Confirmation in Issue Confirmation and Triage Board Jul 12, 2022
@engcom-November engcom-November added the Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it label Jul 12, 2022
@engcom-Echo engcom-Echo self-assigned this Jul 13, 2022
@m2-assistant
Copy link

m2-assistant bot commented Jul 13, 2022

Hi @engcom-Echo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
      DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
    1. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@engcom-Echo
Copy link
Contributor

engcom-Echo commented Jul 14, 2022

Hello @MagePsycho,

This issue is reproducible on Magento 2.4-develop branch.
Please find the below screen for your reference.

Hence we are confirming this issue.

Steps followed as given in above comment.

image

Thanks

@engcom-Echo engcom-Echo added Area: Framework Component: Ui Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Jul 14, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Jul 14, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-5961 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Jul 14, 2022

✅ Confirmed by @engcom-Echo. Thank you for verifying the issue.
Issue Available: @engcom-Echo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Hotel engcom-Hotel added the Priority: P3 May be fixed according to the position in the backlog. label Jul 19, 2022
@m2-community-project m2-community-project bot added this to Ready for Development in Low Priority Backlog Jul 19, 2022
@artskirk
Copy link

@magento I am working on this

@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in Low Priority Backlog Jul 29, 2022
@stkrelax
Copy link

stkrelax commented Aug 11, 2022

also reproduced on 2.4.2-p1

HINT

ONE pagecall ->

Magento\UrlRewrite\Controller\Router\Interceptor returns Magento\Framework\App\Action\Forward\Interceptor
which executes , which causes controller_action_predispatch, which causes getFullactionName be '__'
next is

Magento\Framework\App\Router\Base\Interceptor returns Magento\Catalog\Controller\Product\View\Interceptor
which executes, which causes controller_action_predispatch a second time with getFullactionName be 'catalog_product_view'

@MagePsycho
Copy link
Contributor Author

@stkrelax
Note that controller_action_predispatch is not executed for the next time when the page is served via FPC.

@stkrelax
Copy link

still present in 2.4.5-p1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Framework Component: Ui Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: dev in progress Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Triage: Dev.Experience Issue related to Developer Experience and needs help with Triage to Confirm or Reject it
Projects
Low Priority Backlog
  
Dev In Progress
Development

No branches or pull requests

7 participants