Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQl error in customerOrders query: "\"model\" value should be specified" #35852

Closed
artskirk opened this issue Aug 1, 2022 · 14 comments
Closed
Assignees
Labels
Area: APIs Component: GraphQL GraphQL Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@artskirk
Copy link

artskirk commented Aug 1, 2022

Preconditions and environment

  • Magento 2.4.X

The following GraphQl error occurring in customerOrders query:

This is the body of GraphQl:

``

{
{
           {
         customerOrders { 
       items {
               increment_id
               status 
               order_number
               id 
               created_at
               items
{
 id status } 
      }
  }
  }
  }}

The issue occurring in module-sales-graph-ql/Model/Resolver/OrderItems.php:56. Undefined index $value<'model'> that should contains OrderInterface object

Steps to reproduce

  1. Use the following GraphQl query:

 

{ {          
  {         
    customerOrders {       
                        items { 
                             increment_id 
                            status 
                           order_number id 
                          created_at
                     items { 
                              id status
                                       }
                                    } } }
 }}  
  1. Observe the error output:
    }}`{{ { "errors": < Unknown macro: { "debugMessage"}
    ,
    }}

Expected result

GraphQl works with no errors

Actual result

Internal server error:

Additional information

No response

Release note

No response

Triage and priority

  • [ > Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • < > Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • < > Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • < > Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • < > Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Aug 1, 2022

Hi @artskirk. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-assistant
Copy link

m2-assistant bot commented Aug 1, 2022

Hi @engcom-Lima. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Lima
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @engcom-Lima. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-Lima
Copy link
Contributor

Hi @artskirk ,

Thanks for your contribution and collaboration.

Kindly use query given in official documentation .As query used by you showing deprecated.

{
  customer {
    firstname
    lastname
    suffix
    email
    addresses {
      firstname
      lastname
      street
      city
      region {
        region_code
        region
      }
      postcode
      country_code
      telephone
    }
  }
}

Below is the screenshot for your reference:
image

Let us know if you are facing any issue.

Thanks

@engcom-Lima engcom-Lima added the Issue: needs update Additional information is require, waiting for response label Aug 1, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Aug 1, 2022
@artskirk
Copy link
Author

artskirk commented Aug 2, 2022

Hi @artskirk ,

Thanks for your contribution and collaboration.

Kindly use query given in official documentation .As query used by you showing deprecated.

{
  customer {
    firstname
    lastname
    suffix
    email
    addresses {
      firstname
      lastname
      street
      city
      region {
        region_code
        region
      }
      postcode
      country_code
      telephone
    }
  }
}

Below is the screenshot for your reference: image

Let us know if you are facing any issue.

Thanks

Thank for your feedback! Anyway I would suggest to remove this line from schema.graphqls as deprecated functionality

@artskirk
Copy link
Author

artskirk commented Aug 2, 2022

Hi @artskirk ,
Thanks for your contribution and collaboration.
Kindly use query given in official documentation .As query used by you showing deprecated.

{
  customer {
    firstname
    lastname
    suffix
    email
    addresses {
      firstname
      lastname
      street
      city
      region {
        region_code
        region
      }
      postcode
      country_code
      telephone
    }
  }
}

Below is the screenshot for your reference: image
Let us know if you are facing any issue.
Thanks

Thank for your feedback! Anyway I would suggest to remove this line from schema.graphqls as deprecated functionality

Even is deprecated functionality it should working without issues.
Thank you!

@engcom-Lima
Copy link
Contributor

✔️ Issue confirmed

Issue got reproduced in 2.4-develop branch.

Description: Graph ql error while running query to get details of customer orders.
Pre-requisite:
Fresh magento 2.4-develop should be installed.

Steps to reproduce:

  1. Use the following GraphQl query:
{
  customerOrders {    
    items {
      increment_id
      status         
      order_number
      id      
      created_at
      items {
          id
          status
      }     
    }
  }
}

  1. Check the response.

Expected result: GraphQl works with no errors in the response.
Actual result: Getting error in the response.
Screenshot:
Screenshot from 2022-08-01 20-25-10

Hence, confirming the issue.

@engcom-Lima engcom-Lima added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: GraphQL GraphQL Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: APIs labels Aug 2, 2022
@m2-community-project m2-community-project bot removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Aug 2, 2022
@m2-community-project m2-community-project bot moved this from Needs Update to Confirmed in Issue Confirmation and Triage Board Aug 2, 2022
@m2-community-project m2-community-project bot added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: needs update Additional information is require, waiting for response labels Aug 2, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-6084 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Aug 2, 2022

✅ Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@github-jira-sync-bot

This comment was marked as off-topic.

@artskirk
Copy link
Author

artskirk commented Aug 3, 2022

@magento I am working on this

artskirk pushed a commit to artskirk/magento2-1-fork that referenced this issue Aug 3, 2022
artskirk pushed a commit to artskirk/magento2-1-fork that referenced this issue Aug 4, 2022
@sdzhepa sdzhepa added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Aug 4, 2022
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Aug 4, 2022
@engcom-Lima engcom-Lima added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Aug 8, 2022
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Dev In Progress in High Priority Backlog Sep 1, 2022
@github-jira-sync-bot github-jira-sync-bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: dev in progress labels Sep 6, 2022
@m2-community-project m2-community-project bot moved this from Dev In Progress to Done in High Priority Backlog Sep 30, 2022
@m2-community-project m2-community-project bot removed Progress: PR Created Indicates that Pull Request has been created to fix issue Progress: PR in progress labels Sep 30, 2022
@engcom-Hotel
Copy link
Contributor

Hello,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-6084 by the internal team
Related commits: https://github.com/magento/magento2/search?q=AC-6084&type=commits

Based on the Jira ticket, the target version is 2.4.6.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: APIs Component: GraphQL GraphQL Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
5 participants