Magento Admin Product Custom Options Not Movable / Draggable in 2.4.4

[ksenia-zlotin]

Preconditions and environment

-Magento 2.4.4
-jQuery 3.6.0

Steps to reproduce

1. In a clean Magento 2.4.4 instance, create a product in the admin with 3 custom options.
2. Try to drag the second option up to the first position.

Expected result

Custom option should drag and move to the first position while the first option should move down.

Actual result

The dragging action stops and gets stuck, does not complete.

Additional information

The issue comes from src/vendor/magento/module-ui/view/base/web/js/dynamic-rows/dnd.js:138 where the calculation is made:

drEl.minYpos =
                $table.offset().top - originRecord.offset().top + $table.children('thead').outerHeight();

jQuery updated the way it handles outerHeight function calls. Previously, in Magento 2.4.3-p1 which uses a jQuery version of 1.12.4, jQuery returned Null when outerHeight was called on a non-existent element. Then the minYpos value still returned a number value. This is why in the older Magento version, the drag and move action of custom options in Magento worked. This newer jQuery version used in the newer Magento version, however, returns undefined. Which is why the calculation referenced above returns Nan which breaks the drag and move action.

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @ksenia-zlotin. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Delta]

Hi @ksenia-zlotin ,
Thank you for raising an issue and happy to assist you . We tried to reproduce the issue on magento 2.4.4 instance , but we could not able to drag & drop the options from Product --> custom options --> Option 1 or Option 2 section.
Usually , drag & drop should happen from Catalog--> Category --> section where we can modify its position.

Hence request to review the provided steps.

Reference video.
https://www.loom.com/share/8c7e649dfa92416f9a038d965826f476

[ksenia-zlotin]

It looks like the video shows the reproducing of this issue. What else am I to provide?

[engcom-Delta]

✔️ Issue confirmed

Issue got reproduced in 2.4-develop branch.

Description:

Drag and Drop feature is not working, when trying to do with customizable options of a product.

Pre-requisite:
2.4-develop

Steps to reproduce:

1.Create a product with 3 custom options

2.Try to drag the second option up to the first position

Expected result:

Drag and drop feature should be work .

Actual result:

The dragging action stops and gets stuck, does not complete

Screenshots:
1.Create a product with 3 custom options.

2.Try to drag the second option up to the first position.

Screen.Recording.2022-09-06.at.5.31.02.PM.mov

The dragging action was stopped and stuck and drag and drop is incomplete.

Hence confirming the issue.

Thanks.

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-6636 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[vandijkstef]

Probably to no-one's surprise; I attempted to update to 2.4.5 to see if that resolves this issue, and it didn't.

[maxlussier]

The solution provided with the PR has resolved the issue on my project in Adobe Commerce 2.4.5. I hope someone approves and merges that PR quickly.

[ihor-sviziev]

I'm increasing the priority of this ticket to P2 because this is a regression issue (in 2.4.3 it worked fine) and it breaks pretty-basic functionality - the ability to manage custom options for the products from the admin.

[ihor-sviziev]

Hi @engcom-Delta,
Could you please re-validate this issue because it seems like it got fixed in ACP2E-980

[engcom-Lima]

Hi @ihor-sviziev ,

This issue is partially fixed.
Scenario is create multiple custom options but donot expand the tabs and try to drag from down to up.

Thanks

[norgeindian]

I just applied the changes from ACP2E-980, but unfortunately this does not really solve it.
Does anyone have another approach?

[ihor-sviziev]

The issue was fixed in dd7803a (was added in #36072).

[norgeindian]

@ihor-sviziev , I just tested.
Unfortunately, this does not solve the issue completely.
I can now only move the first of all options to the bottom, but nothing else.
Would you be so kind and check again?
We're using Magento 2.4.5-p2 and at least for this version it seems to be still open.

[ihor-sviziev]

@norgeindian very strange... According to #36072 (comment) it should work as expected

[norgeindian]

@ihor-sviziev , it seems as if according to #36072 (comment) it also does not work for others.

[ihor-sviziev]

@norgeindian could you pls report the separate issue for that? Thank you!
TBH it's very strange that it wasn't properly fixed and tested at first.

[norgeindian]

@ihor-sviziev , I tested again, and it seems as if I had a corrupted test product. I now created a new one, and it actually works.
Thanks for your replies and help.