-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue-36051: Magento Admin Product Custom Options Not Movable / Dragg… #36072
Conversation
Hi @rogerdz. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review. For more details, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento give me test instance |
Hi @Den4ik. Thank you for your request. I'm working on Magento instance for you. |
@magento give me test instance |
@magento give me test instance |
Hi @Den4ik. Thank you for your request. I'm working on Magento instance for you. |
Hi @Den4ik, here is your Magento Instance: https://cb9f13916b4c3598bc1d4315a3f189bc.instances.magento-community.engineering |
@magento give me 2.4-develop instance |
Hi @Den4ik. Thank you for your request. I'm working on Magento instance for you. |
Hi @Den4ik, here is your Magento Instance: https://425b8572c1691925c3490c7a3c773707.instances.magento-community.engineering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Approved
@rogerdz Thanks for contribution
Failed tests are not related to the changes |
@magento run WebAPI Tests,Functional Tests CE,Functional Tests EE,Functional Tests B2B |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests B2B ,Functional Tests CE, Functional Tests EE |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Hi @ihor-sviziev ,
I have tested it by doing directly checkout in Rogerdz branch without merging in the mainline. I have reverified this PR and it is working as expected as mentioned in the comment. Thanks |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
There is a typo in the code on 139. outerHight should be outerHeight. This error is shown when deEl.minYpos is console logged. I'm facing the same issue, but this solution doesn't fix the problem. It does solve the issue of the row snapping, but the rows are still not draggable. |
Looks like this pull request was merged without the latest merge commits, as a result, it wasn't marked as merged |
Description (*)
Magento Admin Product Custom Options Not Movable / Draggable
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)