Issue-36051: Magento Admin Product Custom Options Not Movable / Dragg…

[rogerdz]

Description (*)

Magento Admin Product Custom Options Not Movable / Draggable

Fixed Issues (if relevant)

1. Fixes Magento Admin Product Custom Options Not Movable / Draggable in 2.4.4 #36051

Manual testing scenarios (*)

1. In a clean Magento 2.4.4 instance, create a product in the admin with 3 custom options.
2. Try to drag the second option up to the first position.

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @rogerdz. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[rogerdz]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[rogerdz]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[Den4ik]

@magento give me test instance

[magento-deployment-service]

Hi @Den4ik. Thank you for your request. I'm working on Magento instance for you.

[Den4ik]

@magento give me test instance

[Den4ik]

@magento give me test instance

[magento-deployment-service]

Hi @Den4ik. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @Den4ik, here is your Magento Instance: https://cb9f13916b4c3598bc1d4315a3f189bc.instances.magento-community.engineering
Admin access: https://cb9f13916b4c3598bc1d4315a3f189bc.instances.magento-community.engineering/admin_5a4c
Login: 1aea3ac4
Password: 0dd50e835c27

[Den4ik]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @Den4ik. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @Den4ik, here is your Magento Instance: https://425b8572c1691925c3490c7a3c773707.instances.magento-community.engineering
Admin access: https://425b8572c1691925c3490c7a3c773707.instances.magento-community.engineering/admin_9a98
Login: d4da0899
Password: 55dd707f3620

[Den4ik]

✅ Approved

@rogerdz Thanks for contribution

[Den4ik]

Failed tests are not related to the changes

[engcom-Echo]

@magento run WebAPI Tests,Functional Tests CE,Functional Tests EE,Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Lima]

@magento run Functional Tests B2B ,Functional Tests CE, Functional Tests EE

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Lima]

Hi @ihor-sviziev ,

@engcom-Lima just wonder how did you perform testing, while there were conflicts... 🤔

I have tested it by doing directly checkout in Rogerdz branch without merging in the mainline.

I have reverified this PR and it is working as expected as mentioned in the comment.
Builds are failed hence, again moving back to Extended testing.

Thanks

[engcom-Echo]

Functional Tests CE and Functional Tests B2B failure are different on last two run.
Function Test CE

1. Run1

2. Run2

Functional Test B2B

1. Run1

2. Run2

Hence Moving to Merge In Progress

[engcom-Charlie]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[SimonOnbelet]

There is a typo in the code on 139.
drEl.minYpos = $table.offset().top - originRecord.offset().top + outerHight;

outerHight should be outerHeight. This error is shown when deEl.minYpos is console logged. I'm facing the same issue, but this solution doesn't fix the problem. It does solve the issue of the row snapping, but the rows are still not draggable.

[ihor-sviziev]

Looks like this pull request was merged without the latest merge commits, as a result, it wasn't marked as merged