Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphQL] Price and Category Aggregation Labels are not translated #36140

Closed
1 of 5 tasks
t-heuser opened this issue Sep 14, 2022 · 14 comments · May be fixed by #36655
Closed
1 of 5 tasks

[GraphQL] Price and Category Aggregation Labels are not translated #36140

t-heuser opened this issue Sep 14, 2022 · 14 comments · May be fixed by #36655
Assignees
Labels
Area: Product Component: TranslationGraphQl Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.5 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@t-heuser
Copy link

Preconditions and environment

  • Magento version: 2.4.5
  • A store view with any language thats not english

Steps to reproduce

Execute the following graphql query:

query searchProducts {
    products(search: "") {
        aggregations {
            label
        }
    }
}

This query fetches all available aggregations (filters) and the labels for them.

Expected result

I would expect all labels to be translated into the language of the store (german in my case).

{
  "data": {
    "products": {
      "aggregations": [
        {
          "label": "Preis"
        },
        {
          "label": "Kategorie"
        },
        {
          "label": "Farbe"
        },
        {
          "label": "..."
        },
      ]
    }
  }
}

Actual result

{
  "data": {
    "products": {
      "aggregations": [
        {
          "label": "Price"
        },
        {
          "label": "Category"
        },
        {
          "label": "Farbe"
        },
        {
          "label": "..."
        },
      ]
    }
  }
}

Only the label for the attribute color (Farbe) is translated as set in the adminhtml. The label set for the price attribute is ignored and I can't even set any label for the category attribute.

Additional information

The problem arises because of hardcoded labels in the code:

$result = $this->layerFormatter->buildLayer(
self::$bucketMap[self::CATEGORY_BUCKET]['label'],
\count($categoryIds),
self::$bucketMap[self::CATEGORY_BUCKET]['request_name']
);

private static $bucketMap = [
self::CATEGORY_BUCKET => [
'request_name' => 'category_uid',
'label' => 'Category'
],
];

and

$result = $this->layerFormatter->buildLayer(
self::$bucketMap[self::PRICE_BUCKET]['label'],
\count($bucket->getValues()),
self::$bucketMap[self::PRICE_BUCKET]['request_name']
);

private static $bucketMap = [
self::PRICE_BUCKET => [
'request_name' => 'price',
'label' => 'Price'
],
];

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Sep 14, 2022

Hi @oneserv-heuser. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added this to Ready for Confirmation in Issue Confirmation and Triage Board Sep 14, 2022
@t-heuser t-heuser changed the title [GRAPHQL] Price and Category Aggregation Labels are not translated [GraphQL] Price and Category Aggregation Labels are not translated Sep 14, 2022
@t-heuser
Copy link
Author

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @oneserv-heuser. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @oneserv-heuser, here is your Magento Instance: https://f52c0362d0fdc3db104477f56aabec02.instances.magento-community.engineering
Admin access: https://f52c0362d0fdc3db104477f56aabec02.instances.magento-community.engineering/admin_2488
Login: 856c693f
Password: fdc0e08d3348

@t-heuser
Copy link
Author

I can confirm the issue on a magento vanilla instance.
I set the language for the store to german and translated the labels for the attributes price and color.
Price and category are still in english while color is in german now.

@engcom-Hotel engcom-Hotel added the Reported on 2.4.5 Indicates original Magento version for the Issue report. label Sep 14, 2022
@engcom-Bravo engcom-Bravo self-assigned this Sep 20, 2022
@m2-assistant
Copy link

m2-assistant bot commented Sep 20, 2022

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-Bravo
Copy link
Contributor

engcom-Bravo commented Sep 23, 2022

Hi @oneserv-heuser,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop and 2.4.5 instances and the issue is reproducible on both the instances.
Price,Color and Category Aggregation labels are not translated.kindly refer the screenshots.

Language of the Store Configured as German.

Screenshot 2022-09-23 at 5 51 35 PM

Screenshot 2022-09-23 at 7 13 41 PM

Hence Confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo added Area: Product Component: TranslationGraphQl Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Sep 23, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Sep 23, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-6745 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Sep 23, 2022

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Sep 27, 2022
@m2-community-project m2-community-project bot added this to Ready for Development in High Priority Backlog Sep 27, 2022
@Kannakiraj123
Copy link
Contributor

@magento I am working on this

@engcom-November
Copy link
Contributor

Hi @oneserv-heuser ,
Development team is currently working on this issue.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Product Component: TranslationGraphQl Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.5 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

Successfully merging a pull request may close this issue.

6 participants