-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GraphQL] Price and Category Aggregation Labels are not translated #36140
Comments
Hi @oneserv-heuser. Thank you for your report.
Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:
For more details, review the Magento Contributor Assistant documentation. Add a comment to assign the issue: To learn more about issue processing workflow, refer to the Code Contributions.
🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento give me 2.4-develop instance |
Hi @oneserv-heuser. Thank you for your request. I'm working on Magento instance for you. |
Hi @oneserv-heuser, here is your Magento Instance: https://f52c0362d0fdc3db104477f56aabec02.instances.magento-community.engineering |
I can confirm the issue on a magento vanilla instance. |
Hi @engcom-Bravo. Thank you for working on this issue.
|
@magento give me 2.4-develop instance |
Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you. |
Hi @engcom-Bravo, here is your Magento Instance: https://f52c0362d0fdc3db104477f56aabec02.instances.magento-community.engineering |
Hi @oneserv-heuser, Thank you for reporting and collaboration. Verified the issue on Magento 2.4-develop and 2.4.5 instances and the issue is reproducible on both the instances. Language of the Store Configured as German. Hence Confirming the issue. Thanks. |
✅ Jira issue https://jira.corp.adobe.com/browse/AC-6745 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue. |
@magento I am working on this |
Hi @oneserv-heuser , |
Preconditions and environment
Steps to reproduce
Execute the following graphql query:
This query fetches all available aggregations (filters) and the labels for them.
Expected result
I would expect all labels to be translated into the language of the store (german in my case).
Actual result
Only the label for the attribute
color
(Farbe) is translated as set in the adminhtml. The label set for the price attribute is ignored and I can't even set any label for the category attribute.Additional information
The problem arises because of hardcoded labels in the code:
magento2/app/code/Magento/CatalogGraphQl/DataProvider/Product/LayeredNavigation/Builder/Category.php
Lines 152 to 156 in 91549b9
magento2/app/code/Magento/CatalogGraphQl/DataProvider/Product/LayeredNavigation/Builder/Category.php
Lines 37 to 42 in 91549b9
and
magento2/app/code/Magento/CatalogGraphQl/DataProvider/Product/LayeredNavigation/Builder/Price.php
Lines 60 to 64 in 91549b9
magento2/app/code/Magento/CatalogGraphQl/DataProvider/Product/LayeredNavigation/Builder/Price.php
Lines 33 to 38 in 91549b9
Release note
No response
Triage and priority
The text was updated successfully, but these errors were encountered: