-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.4 develop bugfix aggregation labels are not translated #36655
base: 2.4-develop
Are you sure you want to change the base?
2.4 develop bugfix aggregation labels are not translated #36655
Conversation
Hi @Kannakiraj123. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review. For more details, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Hi @Kannakiraj123 |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Unit Tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failed tests seem flaky to me but can we cover these code changes with some unit/integration test as part of the definition of done?
✔️ QA Passed Preconditions:
Manual testing scenario:
Before: ✖️ Translation was not proper. Builds failures are flaky as per above comments. Hence, moving this PR to Merge in progress |
…ugfix-aggregation-labels-are-not-translated
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
…-are-not-translated
…-are-not-translated
…-are-not-translated
…-are-not-translated
Description (*)
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
1.Set the store view with any language thats not english (german in my case).
2.Execute the following graphql query:
2.Actual Result:
Contribution checklist (*)