Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customer attribute and customer address attribute alway require when select 'Use Default' in config #36196

Closed
5 tasks
rogerdz opened this issue Sep 25, 2022 · 12 comments
Assignees
Labels
Area: Account Component: Customer Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@rogerdz
Copy link
Contributor

rogerdz commented Sep 25, 2022

Preconditions and environment

  • Magento version 2.4-develop

Steps to reproduce

  1. Go Admin - Stores - Configuration - Customers - Customer Configuration
  2. Untick 'Use system value' and set value Required for Show Date of Birth, Show Tax/VAT Number, Show Gender, Show Telephone, Show Company, Show Fax
  3. Save config
  4. Reindex and flush cache
  5. Go edit 1 customer, the fields above are all required
  6. Go Admin - Stores - Configuration - Customers - Customer Configuration
  7. Tick 'Use system value' for Show Date of Birth, Show Tax/VAT Number, Show Gender, Show Telephone, Show Company, Show Fax
  8. Save config
  9. Reindex and clear cache
  10. Go edit 1 customer, the fields above are still required

Expected result

Field Date of Birth, Tax/VAT Number, Gender, Telephone, Company, Fax must display required based on default configuration value
2022-09-25_21-37

Actual result

Field Date of Birth, Tax/VAT Number, Gender, Telephone, Company, Fax still required

2022-09-25_23-01
2022-09-25_23-01_1

Additional information

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Sep 25, 2022

Hi @rogerdz. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-assistant
Copy link

m2-assistant bot commented Sep 26, 2022

Hi @bgorski. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@bgorski bgorski added Component: Customer Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reported on 2.4.x Indicates original Magento version for the Issue report. Area: Account and removed Issue: ready for confirmation labels Sep 26, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Sep 26, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Sep 26, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-6748 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Sep 26, 2022

✅ Confirmed by @bgorski. Thank you for verifying the issue.
Issue Available: @bgorski, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-November engcom-November self-assigned this Sep 27, 2022
@m2-assistant
Copy link

m2-assistant bot commented Sep 27, 2022

Hi @engcom-November. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

    1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    1. If the issue is not relevant or is not reproducible any more, feel free to close it.

@engcom-Hotel
Copy link
Contributor

Hello,

As per the process, all the issues have been confirmed by the Engcom team member. So @engcom-November, I request you to please go through with it and try to reproduce the issue.

Thanks

@engcom-November
Copy link

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @engcom-November. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-November
Copy link

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.
image

@engcom-November engcom-November removed their assignment Sep 29, 2022
@engcom-November engcom-November added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Sep 29, 2022
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Sep 29, 2022
@markshust
Copy link
Contributor

I believe this bug also affects the checkout, as disabling the Company field using config.xml always previously also hid this field from checkout:

<?xml version="1.0"?>
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Store:etc/config.xsd">
    <default>
        <customer>
            <address>
                <company_show>false</company_show>
...

Screenshot 2022-12-26 at 11 10 45 AM

@engcom-Bravo
Copy link
Contributor

Hello,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-6748 by the internal team
Related commits:https://github.com/search?q=repo%3Amagento%2Fmagento2+AC-6748&type=commits

Based on the Jira ticket, the target version is 2.4.7-beta1.

Thanks

@m2-community-project m2-community-project bot moved this from Dev In Progress to Done in High Priority Backlog May 15, 2023
@m2-community-project m2-community-project bot added Progress: done and removed Progress: PR Created Indicates that Pull Request has been created to fix issue Progress: PR in progress labels May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Account Component: Customer Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

Successfully merging a pull request may close this issue.

7 participants