Issue 36196: Customer attribute and customer address attribute alway …

[rogerdz]

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Customer attribute and customer address attribute alway require when select 'Use Default' in config #36196

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @rogerdz. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[rogerdz]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[bgorski]

While in some cases I would say that it's better to add a default value instead of removing canRestore, in this case there's core logic that would get broken if the default value was "No", which is a string that evaluates to 1 or true when cast to integer and boolean respectively. Not to mention any 3rd party logic that could break because of that. So removal of canRestore is definitely a safer and better option.
Approved. Thank you for the contribution!

[bgorski]

To whom it may concern - this PR introduced no data or logic changes to out-of-the-box magento installation (it only affects admins' ability to go back to the initial config - a possibility that in this case never worked anyway) and therefore is not a cause of any test failures. Because of that, failures of integration and functional tests can be disregarded.

[bgorski]

@magento run Integration Tests, Functional Tests CE, Functional Tests EE, Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[bgorski]

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[bgorski]

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Lima]

Hi @rogerdz ,

Thanks for your contribution and collaboration.

As you explained in last comment PR is removing the Use System Value checkbox.
For this we have discussed internally & came to conclusion that It should not be removed as explained below :

1. Use System Value checkbox is in every configuration page of Magento. So, It will break the consistency.
2. In users perspective this will led to confusion. For example-> If any user changes the configuration frequently then,he/she may want to set the configuration to default. Then it is not possible if we remove the checkbox as this checkbox sets the data to Magento default configuration.
3. If only two points in the dropdown is there then, it is fine but here more number of options are there in dropdown. For ex- optional/no/required.
4. On a fresh instance of Magento, when the admin user visits customer creation page for 1st time, all these options like Field - Date of Birth, Tax/VAT Number, Gender, Telephone, Company, Fax fields by default are not mandatory. If user is changing this configuration and restoring back again to default, our expectation is that customer creation page / edit page should be as it was been initially (Customer creation is allowed without these fields. All the default values which were not mandatory initially should be restored back as is)

Also actual issue was reported was that -> After changing the configuration to 'required' for all those options and save it .All mentioned field become mandatory and then, if reporter want to change to system default then, it is not happening by clicking on Use System Value

Please provide your input how to fix it by not removing checkbox.

Thanks

[rogerdz]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[rogerdz]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[rogerdz]

Hi @engcom-Lima, thank you for your response.
I found the way to resolve issue without remove 'Use System Value'
Can you review it ?

[engcom-Lima]

@magento run Functional Tests B2B , Functional Tests CE, Functional Tests EE, Integration Tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[engcom-Lima]

Hi @bgorski ,

As discussed with @rogerdz all necessary changes had been completed. Now, I am moving this PR to Pending Review status. Kindly review it.

Thanks

[rogerdz]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[rogerdz]

@magento run all tests

[magento-automated-testing]

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

[mahesh-singh-rajawat]

@rogerdz Thank you fixing this issue.

It will be taken care into one of the Internal JIRA ticket. Once Internal PR will get merged, we will notify.

Thank you!

[engcom-Bravo]

Hello,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-6748 by the internal team
Related commits:https://github.com/search?q=repo%3Amagento%2Fmagento2+AC-6748&type=commits

Based on the Jira ticket, the target version is 2.4.7-beta1.

Thanks