Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating a product through the API unchecks "Use Default Value" on a bunch of attributes #36429

Closed
1 of 5 tasks
ssstankiewicz opened this issue Nov 7, 2022 · 22 comments
Closed
1 of 5 tasks
Assignees
Labels
Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch

Comments

@ssstankiewicz
Copy link

Preconditions and environment

  • Magento 2.4.5
  • 2 store views

Steps to reproduce

  1. Create 2 store views
  2. Add a new product with a price
  3. Change store view on the product. You can see "Use Default Value" for price is checked.
  4. Update the product using the API, for example uploading an image
  5. View the product again
  6. Notice the "Use Default Value" on Name or Description is now unchecked (other attributes as well)

Expected result

Checkbox "Use Default Value" should remain checked until a user actually unchecks it/add value per store view via API.

Actual result

Checkbox "Use Default Value" unchecks itself when you update the product using the API.

Additional information

In theory this issue was fixed in #26484 but it occurs again.

Product before request:
24-MB01_before_request

Product after request:
24-MB01_after_request

Request endpoint: /rest/en/V1/products/24-MB01/media
Request body:
24-MB01_request.odt

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Nov 7, 2022

Hi @ssstankiewicz. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-assistant
Copy link

m2-assistant bot commented Nov 7, 2022

Hi @engcom-Lima. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Lima
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @engcom-Lima. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-Lima
Copy link
Contributor

engcom-Lima commented Nov 7, 2022

Hi @ssstankiewicz ,

Thanks for your contribution and collaboration.

i have tried to reproduce the issue on 2.4-develop but issue is not reproducible to me. Below are the steps which I have followed:

  1. Created two views.
  2. Created a product.
  3. Changed the Store view and verified "Use Default" checkbox.
  4. Uploaded image from rest api.
  5. Again verified the Use Default checkbox.

Screenshots for your reference:
Before and After update of image:

Before image update:
image

image

After Update:
image

Checked for existing product as well:
image

Kindly provide more information in order to reproduce the issue. Kindly test it in latest 2.4-develop and let us know if you are facing any issue.

Thanks

@engcom-Lima engcom-Lima added the Issue: needs update Additional information is require, waiting for response label Nov 7, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Nov 7, 2022
@ssstankiewicz
Copy link
Author

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @ssstankiewicz. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@ssstankiewicz
Copy link
Author

@magento give me 2.4.5 instance

@magento-deployment-service
Copy link

Hi @ssstankiewicz. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@ssstankiewicz
Copy link
Author

@engcom-Lima I can confirm that issue is not reproducible on 2.4-develop. But on 2.4.5 is. Do you have any idea how to fix it temporarily?

@ssstankiewicz
Copy link
Author

@magento give me 2.4.4 instance

@magento-deployment-service
Copy link

Hi @ssstankiewicz. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @ssstankiewicz, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@engcom-Hotel
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @engcom-Hotel. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-Lima engcom-Lima added Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch and removed Issue: needs update Additional information is require, waiting for response labels Dec 7, 2022
@engcom-Lima
Copy link
Contributor

engcom-Lima commented Dec 7, 2022

Hi @ssstankiewicz ,

Thanks for your confirmation in above comment.
As this issue is not reproducible in latest Magento 2.4-develop. Hence, closing the issue. But for fix we will get back to you with the commit link

Thanks

@bartbollen93
Copy link

Hi @ssstankiewicz , I'm facing the same issue in 2.4.5-p5, did you find a solution for this problem?

@ssstankiewicz
Copy link
Author

Hi @bartbollen93, yes. I attach patch for this issue.

ACSD-48133_2.4.4.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch
Projects
None yet
Development

No branches or pull requests

4 participants