-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The js error when click on video thumbnail in product gallery fullscreen mode #36456
The js error when click on video thumbnail in product gallery fullscreen mode #36456
Comments
Hi @glevhen. Thank you for your report.
Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:
For more details, review the Magento Contributor Assistant documentation. Add a comment to assign the issue: To learn more about issue processing workflow, refer to the Code Contributions.
🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Hi @engcom-Dash. Thank you for working on this issue.
|
@magento give me 2.4-develop instance |
Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you. |
Hi @engcom-Dash, here is your Magento Instance: https://fee3132c24b6aab9293178459434c8a6.instances.magento-community.engineering |
Hi @glevhen , we are trying to reproduce the issue in 2.4-develop branch...But we are not able to reproduce the issue. Steps we followed: We got js error in console.we are not able to reproduce the issue. Let us know if we missing anything!!! Thanks!!! |
@engcom-Dash did you upload the correct screenshot? from I see the attached screenshot is for admin product settings and not for product page gallery on the storefront, and there is no opened product video on your screenshot |
Hi @glevhen , Thanks For your Information....Last time I uploaded wrong screenshot Apologise for that. Preconditions: Steps we followed: 1.Install fresh 2.4-develop Screenshots for your reference: We are reproduced issue in 2.4-develop instance.So we are confirming the issue. Let us know if we missing anything!!! Thanks |
Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Once all required labels are present, please add |
Hello, As I can see this issue got fixed in the scope of the internal Jira ticket AC-7092 by the internal team Based on the Jira ticket, the target version is 2.4.7-beta1. Thanks |
Was there any solution to this? |
@drinkingsouls Change this on line 560 to line 562:
To this:
Now the Product Video will start playing when you click on the thumbnail + the error will not be shown anymore. If you want the videos to autoplay without being in fullscreen mode, you could change the code to:
You will also need to change on line 703: To this: To remove the console errors I recommend editing this too: Copy this file: vendor/magento/magento2-base/lib/web/fotorama/fotorama.js Your addEvent function should look like this: Change this (Line 1141): To this:
And on line 522: This is tested and working on:
The autoplay function is not working on:
|
Preconditions and environment
Steps to reproduce
Expected result
the product video will autoplay and no errors in browser console
Actual result
the js error will appear in the browser console and video will not autoplay
Additional information
the issue is caused by changes in the commit e7a06d3#diff-5d428affd814bd350e233104b8fc3b769544ee7e6d04a9b21a8537473876ffadR605
Release note
No response
Triage and priority
The text was updated successfully, but these errors were encountered: