Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Remove laminas/laminas-dependency-plugin dependency #36515

Closed
2 of 5 tasks
m2-assistant bot opened this issue Nov 23, 2022 · 2 comments · Fixed by #36495
Closed
2 of 5 tasks

[Issue] Remove laminas/laminas-dependency-plugin dependency #36515

m2-assistant bot opened this issue Nov 23, 2022 · 2 comments · Fixed by #36495
Assignees
Labels
Area: Framework Component: Composer Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented Nov 23, 2022

This issue is automatically created based on existing pull request: #36495: Remove laminas/laminas-dependency-plugin dependency


Description (*)

This PR removes the laminas/laminas-dependency-plugin composer plugin.
The plugin was introduced in #26436 and its purpose is described as follows on their homepage:

This Composer plugin, when enabled in a project, intercepts requests to install packages from the zendframework and zfcampus vendors, and will replace them with the equivalents from the Laminas Project.

Reason why I think we should get rid of this, is that I'm currently unable to use a modern version of composer to install dependencies on the 2.4-develop branch:

$ composer --version
Composer version 2.4.4 2022-10-27 14:39:29

$ composer install
Installing dependencies from lock file (including require-dev)
Verifying lock file contents can be installed on current platform.
In Laminas\DependencyPlugin\DependencyRewriterV2::onPrePoolCreate
Your lock file does not contain a compatible set of packages. Please run composer update.

  Problem 1
    - laminas/laminas-dependency-plugin is locked to version 2.5.0 and an update of this package was not requested.
    - laminas/laminas-dependency-plugin 2.5.0 requires composer-plugin-api >=1.1.0 <2.3.0 -> found composer-plugin-api[2.3.0] but it does not match the constraint.

Which was a restriction added to that plugin in laminas/laminas-dependency-plugin@54d508a

I believe that after 2 years since Magento switched from Zend to Laminas, that this plugin is not really necessary anymore, most people will have gotten used to the Laminas components by now and should install those instead of the old Zend ones.

// cc @ihor-sviziev

Related Pull Requests

Fixed Issues (if relevant)

None that I know of

Manual testing scenarios (*)

  1. Use composer 2.3.x or 2.4.x
  2. Try to run composer install without getting errors

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Nov 23, 2022
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Nov 23, 2022
@engcom-Lima engcom-Lima added Component: Composer Area: Framework Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reported on 2.4.x Indicates original Magento version for the Issue report. Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Nov 23, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-7100 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Nov 23, 2022

✅ Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Framework Component: Composer Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

Successfully merging a pull request may close this issue.

3 participants