-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove laminas/laminas-dependency-plugin dependency #36495
Remove laminas/laminas-dependency-plugin dependency #36495
Conversation
Hi @hostep. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review. For more details, review the Magento Contributor Guide documentation. 🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
Failing tests don't seem to have anything to do with the changes in this PR. |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
1 similar comment
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
As to me it fully make sense to remove this plugin as part of platform health project. |
fb3bcc3
to
f81e6cd
Compare
Rebased on latest 2.4-develop, because conflicts were introduced recently by e11b3bc I'm afraid this will keep happening if the composer files are being updated all the time. The maintainers here have my permission to fix conflicts themselves in this PR during my holiday period (end November till end December). @magento run all tests |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento create issue |
@magento run Integration Tests, Functional Tests EE, Functional Tests B2B |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests EE |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
3 similar comments
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Functional Tests B2B, Functional Tests EE |
The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time. |
@magento run Adobe CLA Signed? |
Failed to run the builds. Please try to re-run them later. |
@magento run Adobe CLA Signed? |
Failed to run the builds. Please try to re-run them later. |
Description (*)
This PR removes the
laminas/laminas-dependency-plugin
composer plugin.The plugin was introduced in #26436 and its purpose is described as follows on their homepage:
Reason why I think we should get rid of this, is that I'm currently unable to use a modern version of composer to install dependencies on the
2.4-develop
branch:Which was a restriction added to that plugin in laminas/laminas-dependency-plugin@54d508a
I believe that after 2 years since Magento switched from Zend to Laminas, that this plugin is not really necessary anymore, most people will have gotten used to the Laminas components by now and should install those instead of the old Zend ones.
// cc @ihor-sviziev
Related Pull Requests
Fixed Issues (if relevant)
None that I know of
Manual testing scenarios (*)
composer install
without getting errorsQuestions or comments
Contribution checklist (*)
Resolved issues: