[Issue] Remove 'version' manipulation from sampledata:deploy, improve success messaging #36554
Closed
5 tasks done
Labels
Area: Framework
Area: Install & Administer
Component: SampleData
Issue: Confirmed
Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed
Priority: P2
A defect with this priority could have functionality issues which are not to expectations.
Progress: done
Reported on 2.4.x
Indicates original Magento version for the Issue report.
Reproduced on 2.4.x
The issue has been reproduced on latest 2.4-develop branch
This issue is automatically created based on existing pull request: #36187: Remove 'version' manipulation from sampledata:deploy, improve success messaging
Description
When running
bin/magento sampledata:deploy
, an error message is shown regarding a missingversion
key incomposer.json
. The linked page provided in the error message says thatversion
should not be present incomposer.json
. Thesampledata:deploy
command then tries to add a 'version' key tocomposer.json
with varying degrees of success. When this is coupled with the lack of success message, developers are left wondering if the command was successful or not. The 'version' string withincomposer.json
is not required nor used by anything in this module, and should not be present.This pull request adds a success message and instructions on what to do next for developers to follow when the command is successful, and removes any manipulation of 'version' within
composer.json
.Manual testing scenarios
No success message
bin/magento sampledata:deploy
'version' requirement in
composer.json
composer.json
has noversion
key (according to Composer best practices)bin/magento sampledata:deploy
composer.json
Contribution checklist
The text was updated successfully, but these errors were encountered: