Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Remove 'version' manipulation from sampledata:deploy, improve success messaging #36554

Closed
5 tasks done
m2-assistant bot opened this issue Dec 1, 2022 · 2 comments · Fixed by #36187
Closed
5 tasks done
Assignees
Labels
Area: Framework Area: Install & Administer Component: SampleData Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented Dec 1, 2022

This issue is automatically created based on existing pull request: #36187: Remove 'version' manipulation from sampledata:deploy, improve success messaging


Description

When running bin/magento sampledata:deploy, an error message is shown regarding a missing version key in composer.json. The linked page provided in the error message says that version should not be present in composer.json. The sampledata:deploy command then tries to add a 'version' key to composer.json with varying degrees of success. When this is coupled with the lack of success message, developers are left wondering if the command was successful or not. The 'version' string within composer.json is not required nor used by anything in this module, and should not be present.

This pull request adds a success message and instructions on what to do next for developers to follow when the command is successful, and removes any manipulation of 'version' within composer.json.

Manual testing scenarios

No success message

  1. Run bin/magento sampledata:deploy
  2. Witness (lack of) success messaging when the command completes successfully

'version' requirement in composer.json

  1. Ensure that composer.json has no version key (according to Composer best practices)
  2. Run bin/magento sampledata:deploy
  3. Witness (lack of) error messaging and (lack of) changes in composer.json

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Dec 1, 2022
@engcom-Lima engcom-Lima added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reported on 2.4.x Indicates original Magento version for the Issue report. Reported on 2.4.5-p1 Indicates original Magento version for the Issue report. Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: SampleData Area: Framework Area: Install & Administer and removed Reported on 2.4.5-p1 Indicates original Magento version for the Issue report. labels Dec 1, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-7300 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Dec 1, 2022

✅ Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Framework Area: Install & Administer Component: SampleData Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants