Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento 2.4.5-p1 - Email preview window height #36593

Closed
2 of 5 tasks
pmonosolo opened this issue Dec 9, 2022 · 9 comments
Closed
2 of 5 tasks

Magento 2.4.5-p1 - Email preview window height #36593

pmonosolo opened this issue Dec 9, 2022 · 9 comments
Assignees
Labels
Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: needs update Additional information is require, waiting for response Reported on 2.4.5-p1 Indicates original Magento version for the Issue report.

Comments

@pmonosolo
Copy link

pmonosolo commented Dec 9, 2022

Preconditions and environment

  • Magento version 2.4.5-p1

Email preview is shown in a short height window:

image

Steps to reproduce

  1. Go to Marketing -> Email Templates

  2. Add new template

  3. Load template New Invoice

  4. Save template

  5. Click "Preview"

Expected result

  • Full sized email template preview without scrolling

image

Actual result

Real output:

image

Additional information

Something is going on with the Iframe resizing. Did not dig into the issue myself yet.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Dec 9, 2022

Hi @pmonosolo. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@pmonosolo
Copy link
Author

There are some JS errors in the console:

Uncaught TypeError: url.indexOf is not a function at jQuery.fn.load (jquery.js:10363:23) at (index):50:26 at Object.execCb (require.js:1696:33) at Module.check (require.js:883:51) at Module.enable (require.js:1176:22) at Module.init (require.js:788:26) at require.js:1460:36

And

Blocked script execution in 'http://vanillamagento.ca/admin/admin/email_template/popup/key/3861b00fe3fa9c85c88caecdd2455b6e7bb418512d4cef5b4c616f382f56d1a4/' because the document's frame is sandboxed and the 'allow-scripts' permission is not set.

@pmonosolo
Copy link
Author

@magento give me 2.4-5-p1 instance

@magento-deployment-service
Copy link

Hi @pmonosolo. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @pmonosolo, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@engcom-Bravo engcom-Bravo self-assigned this Dec 10, 2022
@m2-assistant
Copy link

m2-assistant bot commented Dec 10, 2022

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.5-p1 Indicates original Magento version for the Issue report. label Dec 10, 2022
@ihor-sviziev
Copy link
Contributor

Hi @pmonosolo,
It looks like a duplicate of #35697, which was already fixed in #35816, but wasn't included to any release yet

@engcom-Bravo
Copy link
Contributor

Thanks for your Contribution @ihor-sviziev,

Hi @pmonosolo,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is not reproducible.Kindly refer the screenshots.

Steps to reproduce

1.Go to Marketing -> Email Templates

2.Add new template

3.Load template New Invoice

4.Save template

5.Click "Preview"

Screenshot 2022-12-12 at 2 15 23 PM

Kindly recheck the behavior on Magento 2.4-develop instance and elaborate steps to reproduce if the issue is still reproducible

Thanks.

@engcom-Bravo engcom-Bravo added the Issue: needs update Additional information is require, waiting for response label Dec 12, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Dec 12, 2022
@engcom-Bravo engcom-Bravo added the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label Dec 12, 2022
@pmonosolo
Copy link
Author

Thanks @engcom-Bravo and @ihor-sviziev!

Confirmed, this one already solved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: needs update Additional information is require, waiting for response Reported on 2.4.5-p1 Indicates original Magento version for the Issue report.
Projects
None yet
Development

No branches or pull requests

3 participants