Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix email preview template cut off #35816

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

sheepfy
Copy link
Contributor

@sheepfy sheepfy commented Jul 26, 2022

Jquery 3.6 doesn't have .load anymore.

Resolves #35697

@m2-assistant
Copy link

m2-assistant bot commented Jul 26, 2022

Hi @sheepfy. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@sdzhepa sdzhepa added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jul 28, 2022
@ihor-sviziev
Copy link
Contributor

That's interesting that we have two different solutions for a single issue #35705 and #35816

@ihor-sviziev
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

2 similar comments
@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Lima
Copy link
Contributor

engcom-Lima commented Oct 19, 2022

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Manual testing scenario:

  1. Go to Marketing->Communications->Email Templates.
  2. Go to any email template.
  3. Click “preview template”

Before: ✖️ Email template was clipped.
image

After: ✔️ Email template is displaying properly.
Payment failed email template:
Screenshot 2022-10-19 at 12 31 14 PM

New account email template:
Screenshot 2022-10-19 at 12 30 51 PM

Additionally tested:

  • Created Email templates.
  • Tested with more number of email templates.
  • Deleted the email templates.

Since its minor code changes no additional manual testcase is required.

@ihor-sviziev ihor-sviziev changed the title FIX ISSUE 35697 Fix email preview template cut off Oct 19, 2022
@engcom-Lima
Copy link
Contributor

Looking like bot moved from Merge in Progress to ready for testing. Hence, moving again to Merge in Progress

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Email template preview issues
5 participants