Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Refactor Google Adwords Code Template #36641

Closed
5 tasks done
m2-assistant bot opened this issue Dec 20, 2022 · 2 comments · Fixed by #36329
Closed
5 tasks done

[Issue] Refactor Google Adwords Code Template #36641

m2-assistant bot opened this issue Dec 20, 2022 · 2 comments · Fixed by #36329
Assignees
@pykettk
Labels
Area: Admin UI Component: GoogleAdwords Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented Dec 20, 2022

This issue is automatically created based on existing pull request: #36329: Refactor Google Adwords Code Template

Description (*)

Refactors the Google Adwords code template

  • Use correct and non-deprecated escaping functions
  • Simplify FQNs
  • Formatted for improved readability

Manual testing scenarios (*)

  1. There should be no changes to the output or functionality of the Google Adwords code

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added the Priority: P3 May be fixed according to the position in the backlog. label Dec 20, 2022
@m2-assistant m2-assistant bot mentioned this issue Dec 20, 2022
Merged
6 tasks
@engcom-Lima engcom-Lima added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Component: GoogleAdwords Reported on 2.4.x Indicates original Magento version for the Issue report. Area: Admin UI labels Dec 20, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-7500 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Dec 20, 2022

✅ Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pykettk pykettk

Labels
Area: Admin UI Component: GoogleAdwords Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Low Priority Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Google Adwords Code Template
3 participants
@pykettk @engcom-Lima @github-jira-sync-bot