-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: urlResolver
and route
queries error in Varnish when url has certain queryParams
#37524
Comments
Hi @damienwebdev. Thank you for your report.
Join Magento Community Engineering Slack and ask your questions in #github channel. |
Hi @engcom-Hotel. Thank you for working on this issue.
|
Hello @damienwebdev, Thanks for the report and collaboration! We have tried to reproduce the issue in the latest 2.4-develop branch with Varnish enable. But it seems the issue is not reproducible for us. We are getting the below response: Might be this is due to we do not have a proper URL. Can you please let us know how do you get the below URL:
Thanks |
@engcom-Hotel can you post:
|
Hello @damienwebdev, Please find attached the VCL file we are using: And we are not able to get any logs in the varnish.log file. Thanks |
Ok. Well I think you should figure out how to get your Varnish log before proceeding further. |
Hello @damienwebdev, We have tried again to reproduce this issue, now we are getting the logs in varnishlog, please have a look into the below screenshot for reference: We are able to reproduce the issue: Hence confirming the issue. Thanks |
✅ Jira issue https://jira.corp.adobe.com/browse/AC-11858 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue. |
Preconditions and environment
Steps to reproduce
Note the param
?utm_medium
. This matches the VCL linked above, causing an over-aggressive removal of string contents.The request being sent to Magento has a url encoded
variables
key in the queryParams that is supposed to look like this decoded:Instead, due to the over-matching, it looks like:
Expected result
A successful response like:
Actual result
Additional information
No response
Release note
No response
Triage and priority
The text was updated successfully, but these errors were encountered: