Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report.CRITICAL: TypeError on Login as Customer #37723

Closed
5 tasks
lfluvisotto opened this issue Jul 5, 2023 · 9 comments
Closed
5 tasks

report.CRITICAL: TypeError on Login as Customer #37723

lfluvisotto opened this issue Jul 5, 2023 · 9 comments
Assignees
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.5-p3 Indicates original Magento version for the Issue report.

Comments

@lfluvisotto
Copy link
Contributor

lfluvisotto commented Jul 5, 2023

Preconditions and environment

  • Adobe Commerce ver. 2.4.5-p3

Steps to reproduce

  1. Customers > All customers > Select any customer
  2. Click on login as customer

Expected result

Login as customer selected.

Actual result

[2023-07-05T21:34:34.018540+00:00] report.CRITICAL: TypeError: Magento\LoginAsCustomer\Model\AuthenticateCustomerBySecret\Interceptor::execute(): Argument #1 ($secret) must be of type string, null given, called in /app/4ebxve7ph74no/vendor/magento/module-login-as-customer-frontend-ui/Controller/Login/Index.php on line 113 and defined in /app/4ebxve7ph74no/generated/code/Magento/LoginAsCustomer/Model/AuthenticateCustomerBySecret/Interceptor.php:20
Stack trace:
#0 /app/4ebxve7ph74no/vendor/magento/module-login-as-customer-frontend-ui/Controller/Login/Index.php(113): Magento\LoginAsCustomer\Model\AuthenticateCustomerBySecret\Interceptor->execute(NULL)
#1 /app/4ebxve7ph74no/vendor/magento/framework/Interception/Interceptor.php(58): Magento\LoginAsCustomerFrontendUi\Controller\Login\Index->execute()
#2 /app/4ebxve7ph74no/vendor/magento/framework/Interception/Interceptor.php(138): Magento\LoginAsCustomerFrontendUi\Controller\Login\Index\Interceptor->___callParent('execute', Array)
#3 /app/4ebxve7ph74no/vendor/magento/framework/Interception/Interceptor.php(153): Magento\LoginAsCustomerFrontendUi\Controller\Login\Index\Interceptor->Magento\Framework\Interception\{closure}()
#4 /app/4ebxve7ph74no/generated/code/Magento/LoginAsCustomerFrontendUi/Controller/Login/Index/Interceptor.php(23): Magento\LoginAsCustomerFrontendUi\Controller\Login\Index\Interceptor->___callPlugins('execute', Array, Array)
#5 /app/4ebxve7ph74no/vendor/magento/framework/App/FrontController.php(248): Magento\LoginAsCustomerFrontendUi\Controller\Login\Index\Interceptor->execute()
#6 /app/4ebxve7ph74no/vendor/magento/framework/App/FrontController.php(212): Magento\Framework\App\FrontController->getActionResponse(Object(Magento\LoginAsCustomerFrontendUi\Controller\Login\Index\Interceptor), Object(Magento\Framework\App\Request\Http))
#7 /app/4ebxve7ph74no/vendor/magento/framework/App/FrontController.php(147): Magento\Framework\App\FrontController->processRequest(Object(Magento\Framework\App\Request\Http), Object(Magento\LoginAsCustomerFrontendUi\Controller\Login\Index\Interceptor))
#8 /app/4ebxve7ph74no/vendor/magento/framework/Interception/Interceptor.php(58): Magento\Framework\App\FrontController->dispatch(Object(Magento\Framework\App\Request\Http))
#9 /app/4ebxve7ph74no/vendor/magento/framework/Interception/Interceptor.php(138): Magento\Framework\App\FrontController\Interceptor->___callParent('dispatch', Array)
#10 /app/4ebxve7ph74no/vendor/magento/module-store/App/FrontController/Plugin/RequestPreprocessor.php(99): Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception\{closure}(Object(Magento\Framework\App\Request\Http))
#11 /app/4ebxve7ph74no/vendor/magento/framework/Interception/Interceptor.php(135): Magento\Store\App\FrontController\Plugin\RequestPreprocessor->aroundDispatch(Object(Magento\Framework\App\FrontController\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#12 /app/4ebxve7ph74no/vendor/fastly/magento2/Model/FrontControllerPlugin.php(135): Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception\{closure}(Object(Magento\Framework\App\Request\Http))
#13 /app/4ebxve7ph74no/vendor/magento/framework/Interception/Interceptor.php(135): Fastly\Cdn\Model\FrontControllerPlugin->aroundDispatch(Object(Magento\Framework\App\FrontController\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#14 /app/4ebxve7ph74no/vendor/amasty/aminvisiblecaptcha/Plugin/Framework/App/FrontControllerInterface/ValidateCaptcha.php(124): Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception\{closure}(Object(Magento\Framework\App\Request\Http))
#15 /app/4ebxve7ph74no/vendor/magento/framework/Interception/Interceptor.php(135): Amasty\InvisibleCaptcha\Plugin\Framework\App\FrontControllerInterface\ValidateCaptcha->aroundDispatch(Object(Magento\Framework\App\FrontController\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#16 /app/4ebxve7ph74no/vendor/magento/module-page-cache/Model/App/FrontController/BuiltinPlugin.php(71): Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception\{closure}(Object(Magento\Framework\App\Request\Http))
#17 /app/4ebxve7ph74no/vendor/magento/framework/Interception/Interceptor.php(135): Magento\PageCache\Model\App\FrontController\BuiltinPlugin->aroundDispatch(Object(Magento\Framework\App\FrontController\Interceptor), Object(Closure), Object(Magento\Framework\App\Request\Http))
#18 /app/4ebxve7ph74no/vendor/magento/framework/Interception/Interceptor.php(153): Magento\Framework\App\FrontController\Interceptor->Magento\Framework\Interception\{closure}(Object(Magento\Framework\App\Request\Http))
#19 /app/4ebxve7ph74no/generated/code/Magento/Framework/App/FrontController/Interceptor.php(23): Magento\Framework\App\FrontController\Interceptor->___callPlugins('dispatch', Array, NULL)
#20 /app/4ebxve7ph74no/vendor/magento/framework/App/Http.php(116): Magento\Framework\App\FrontController\Interceptor->dispatch(Object(Magento\Framework\App\Request\Http))
#21 /app/4ebxve7ph74no/vendor/magento/framework/App/Bootstrap.php(264): Magento\Framework\App\Http->launch()
#22 /app/4ebxve7ph74no/pub/index.php(30): Magento\Framework\App\Bootstrap->run(Object(Magento\Framework\App\Http\Interceptor))
#23 {main} [] []

Additional information

No response

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Jul 5, 2023

Hi @lfluvisotto. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@m2-community-project m2-community-project bot added this to Ready for Confirmation in Issue Confirmation and Triage Board Jul 5, 2023
@lfluvisotto lfluvisotto changed the title Login as Customer report.CRITICAL: TypeError on Login as Customer Jul 5, 2023
@engcom-Bravo engcom-Bravo self-assigned this Jul 6, 2023
@m2-assistant
Copy link

m2-assistant bot commented Jul 6, 2023

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.5-p3 Indicates original Magento version for the Issue report. label Jul 6, 2023
@engcom-Bravo
Copy link
Contributor

Hi @lfluvisotto,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance with EE edition and the issue is not reproducible.Kindly refer the attached video.

Steps to reproduce

  • Customers > All customers > Select any customer
  • Click on login as customer
d6c353d5-06a4-4856-982b-7e406809a121.mp4

We are able to click login as customer and customer is able to login successfully.

Kindly recheck the behaviour on Magento 2.4-develop instance with EE edition. and elaborate steps to reproduce if the issue is still reproducible.

Thanks.

@engcom-Bravo engcom-Bravo added the Issue: needs update Additional information is require, waiting for response label Jul 6, 2023
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Jul 6, 2023
@lfluvisotto
Copy link
Contributor Author

lfluvisotto commented Jul 6, 2023

@engcom-Bravo
PR #37729

@engcom-Bravo
Copy link
Contributor

Hi @lfluvisotto,

Thanks for your update.

As per this comment #37723 (comment) issue is not reproducible in Magento 2.4-develop instance could please provide update and elaborate the steps to reproduce if we are missing anything.

Kindly recheck the behaviour on Magento 2.4-develop instance with EE edition. and elaborate steps to reproduce if the issue is still reproducible.

Thanks.

@engcom-Bravo
Copy link
Contributor

Hi @lfluvisotto,

We have noticed that this issue has not been updated since long time.
Hence we assume that this issue is fixed now, so we are closing it. Please feel to raise a fresh ticket or reopen this ticket if you need more assistance on this.

Thanks.

@engcom-Lima
Copy link
Contributor

@magento give me 2.4.5 instance

@magento-deployment-service
Copy link

Hi @engcom-Lima. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @engcom-Lima, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: needs update Additional information is require, waiting for response Reported on 2.4.5-p3 Indicates original Magento version for the Issue report.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants