ProductRepository is loading initializationHelper which is an Adminhtml controller

[MrBlueEyez]

Summary

The Magento\Catalog\Model\ProductRepository is loading the Magento\Catalog\Controller\Adminhtml\Product\Initialization\Helper in its constructor, but then continues to not use it.

This, on a first look, doesn't seem to cause any issues. However when using some third party modules which extend the PathInfoProcessor and that uses the productRepository this is causing some issues with loading in di.xml configurations.

When trying to use the rest-api with an oauth authorization, the Magento\Framework\App\Http class is triggered, which first tries to get the area code of the current url. But then the custom logic by the third party is triggered, finally loading in the productRepository. The productRepository then tries to load the above mentioned adminhtml controller, which tries to access the roleLocatorInterface, which is now not based on the webapi_rest/di.xml, but on the default app/etc/di.xml. Causing the Magento\Framework\Authorization\RoleLocator\DefaultRoleLocator to be loaded instead of the Magento\Framework\Authorization\RoleLocatorInterface\WebapiRoleLocator. This last thing causes the authorization to fail, as the DefaultRoleLocator returns '' instead of executing logic like the WebapiRoleLocator.

There is currently no workaround for this.

Examples

The only thing that is required to be changed for this to work is to remove the \Magento\Catalog\Controller\Adminhtml\Product\Initialization\Helper $initializationHelper, in Magento\Catalog\Model\ProductRepository on line 225.

Which is causing this issue, and isn't being used in the file at all.

Proposed solution

Remove the loading of \Magento\Catalog\Controller\Adminhtml\Product\Initialization\Helper $initializationHelper, inside the Magento\Catalog\Model\ProductRepository.

Release note

Removing unused Magento\Catalog\Controller\Adminhtml\Product\Initialization\Helper from Magento\Catalog\Model\ProductRepository

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @MrBlueEyez. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[MrBlueEyez]

Just been looking back into the history:
In 2.0.18 the helper is being used.
https://github.com/magento/magento2/blob/2.0.18/app/code/Magento/Catalog/Model/ProductRepository.php

But the usage is removed in 2.1.0 and beyond:
https://github.com/magento/magento2/blob/2.1.0/app/code/Magento/Catalog/Model/ProductRepository.php

[ihor-sviziev]

Good catch!

[BeggiNN]

@magento I am working on this

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @MrBlueEyez,

Thanks for the report and collaboration!

We have tried to reproduce the issue in Magento 2.4-develop branch by looking into the codebase. And it seems the issue is reproducible for us.

$this->initializationHelper is not in use and the scenario mentioned in the main description seems valid.

Hence confirming the issue.

Thanks

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-9302 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.