GraphQL addProductsToCart mutation reports unrelated errors in user_errors

[paales]

Preconditions and environment

• 2.4.6-p2
• Demo products available
• MSI configured (although not known if it is a specific MSI issue)

Steps to reproduce

1. Create a product "PRODUCT-1" with inventory of 100

2. Create a product "PRODUCT-2" with inventory of 100 (make sure indexers etc. have ran)

3. Create an empty cart:

mutation {
  createEmptyCart(input: {cart_id: "CART_ID_CART_ID_CART_ID_CART_ID_"})
}

4. Add a product with for quantity of 100 to the cart.

mutation AddProductOne {
  addProductsToCart(cartId: "CART_ID_CART_ID_CART_ID_CART_ID_", cartItems: [{
    sku: "PRODUCT-1",
    quantity: 100
  }]) {
    cart {
      items {
        ... on SimpleCartItem {
          quantity
        }
        errors {
          code
          message
        }
      }
    }
    user_errors {
      code
      message
    }
  }
}

5. Run this mutation again, you will see an error on user_errors, this is correct.
6. Change the quantity of PRODUCT-1 to 50 in the backend
7. Validate that the items[0].errors has entries:

query GetCart {
  cart(cart_id: "CART_ID_CART_ID_CART_ID_CART_ID_") {
    items {
      ... on SimpleCartItem {
        quantity
      }
      product {
        sku
      }
      errors {
        code
        message
      }
    }
  }
}

8. Add the second product to the cart with quantity of 1

mutation {
  addProductsToCart(cartId: "CART_ID_CART_ID_CART_ID_CART_ID_", cartItems: [{
    sku: "PRODUCT-2",
    quantity: 1
  }]) {
    cart {
      items {
        ... on SimpleCartItem {
          quantity
        }
        product {
          sku
        }
        errors {
          code
          message
        }
      }
    }
    user_errors {
      code
      message
    }
  }
}

Expected result

I would expect the user_errors to be empty because there was no error with the operation, only an error with the cart it's self.

Actual result

user_errors contains the error of the other item..

Additional information

We currently have to do some very dirty checking to see on which item this error occurs and do a string match on the message to filter any cart item errors. This is not foolproof and is slow when there are many items in the cart. This issue arises because add to cart actions become very slow when there are many items in the cart because we fetch those items on each action.

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @paales. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @engcom-Bravo. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @engcom-Bravo, here is your Magento Instance: https://1f608a5579e160b07d8a456159c267c7.instances-prod.magento-community.engineering
Admin access: https://1f608a5579e160b07d8a456159c267c7.instances-prod.magento-community.engineering/admin_10d3
Login: 9e59911a
Password: ea0267e4eb96

[engcom-Bravo]

Hi @paales,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Steps to reproduce

• Create a product "PRODUCT-1" with inventory of 100
• Create a product "PRODUCT-2" with inventory of 100 (make sure indexers etc. have ran)
• Create an empty cart:

mutation {
  createEmptyCart(input: {cart_id: "CART_ID_CART_ID_CART_ID_CART_ID_"})
}

• Add a product with for quantity of 100 to the cart.

mutation AddProductOne {
  addProductsToCart(cartId: "CART_ID_CART_ID_CART_ID_CART_ID_", cartItems: [{
    sku: "PRODUCT-1",
    quantity: 100
  }]) {
    cart {
      items {
        ... on SimpleCartItem {
          quantity
        }
        errors {
          code
          message
        }
      }
    }
    user_errors {
      code
      message
    }
  }
}

• Run this mutation again, you will see an error on user_errors, this is correct.
• Change the quantity of PRODUCT-1 to 50 in the backend
• Validate that the items[0].errors has entries:

query GetCart {
  cart(cart_id: "CART_ID_CART_ID_CART_ID_CART_ID_") {
    items {
      ... on SimpleCartItem {
        quantity
      }
      product {
        sku
      }
      errors {
        code
        message
      }
    }
  }
}

• Add the second product to the cart with quantity of 1

mutation {
  addProductsToCart(cartId: "CART_ID_CART_ID_CART_ID_CART_ID_", cartItems: [{
    sku: "PRODUCT-2",
    quantity: 1
  }]) {
    cart {
      items {
        ... on SimpleCartItem {
          quantity
        }
        product {
          sku
        }
        errors {
          code
          message
        }
      }
    }
    user_errors {
      code
      message
    }
  }
}

We have added a PRODUCT-1 with qty 100.

Here We are getting errors it is expected.

We are getting user errors while adding PRODUCT-2 it is having sufficient stock and quantity there is no issue with this product.There should be no errors still we are getting errors.

Hence Confirming the issue.

Thanks.

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-9362 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[Vasudev-22]

@magento I am working on this