Mail templates sent with scheduler don't get translated

[nobodypb]

If I sent mails using cron they won't get translated, because PART_TRANSLATE is never loaded in the App\Area.
To quick fix this I added

$areaObject = $this->_areaList->getArea($this->getDesignConfig()->getArea());
$areaObject->load(\Magento\Framework\App\Area::PART_TRANSLATE);

to \Magento\Email\Model\AbstractTemplate::applyDesignConfig()
(And some di things for _areaList)

I don't know if that bug is somehow related to my setup, I'm running Magento 2.0.2 on php7

[srbarba]

I have the same problem.
Thank you @nobodypb , Your fix solved my issue! :D

Please, add this fix to future releases!

[JDavidVR]

Hi @srbarba , @nobodypb can you clarify the solution

just for test I edited file: vendor/magento/module-email/Model/AbstractTemplate.php

in constructor I added:

protected $_areaList;
public function __construct(
        \Magento\Framework\Model\Context $context,
        \Magento\Framework\View\DesignInterface $design,
        \Magento\Framework\Registry $registry,
        \Magento\Framework\App\AreaList $areaList, // <-----------------
        \Magento\Store\Model\App\Emulation $appEmulation,
        \Magento\Store\Model\StoreManagerInterface $storeManager,
        \Magento\Framework\View\Asset\Repository $assetRepo,
        \Magento\Framework\Filesystem $filesystem,
        \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfig,
        \Magento\Email\Model\Template\Config $emailConfig,
        \Magento\Email\Model\TemplateFactory $templateFactory,
        \Magento\Framework\Filter\FilterManager $filterManager,
        \Magento\Framework\UrlInterface $urlModel,
        array $data = []
    ) {
        $this->design = $design;
        $this->area = isset($data['area']) ? $data['area'] : null;
        $this->store = isset($data['store']) ? $data['store'] : null;
        $this->appEmulation = $appEmulation;
        $this->_areaList = $areaList; // <-----------------
        $this->storeManager = $storeManager;
        $this->assetRepo = $assetRepo;
        $this->filesystem = $filesystem;
        $this->scopeConfig = $scopeConfig;
        $this->emailConfig = $emailConfig;
        $this->templateFactory = $templateFactory;
        $this->filterManager = $filterManager;
        $this->urlModel = $urlModel;
        parent::__construct($context, $registry, null, null, $data);
    }

and in method applyDesignConfig()

protected function applyDesignConfig()
    {
        $areaObject = $this->_areaList->getArea($this->getDesignConfig()->getArea()); //<--------
        $areaObject->load(\Magento\Framework\App\Area::PART_TRANSLATE); //<------

        // Only run app emulation if this is the parent template and emulation isn't already running.
        // Otherwise child will run inside parent emulation.
        if ($this->isChildTemplate() || $this->hasDesignBeenApplied) {
            return false;
        }
        $this->hasDesignBeenApplied = true;

        $designConfig = $this->getDesignConfig();
        $storeId = $designConfig->getStore();
        $area = $designConfig->getArea();
        if ($storeId !== null) {
            // Force emulation in case email is being sent from same store so that theme will be loaded. Helpful
            // for situations where emails may be sent from bootstrap files that load frontend store, but not theme
            $this->appEmulation->startEnvironmentEmulation($storeId, $area, true);
        }
        return true;
    }

but when I change order status from backend it is giving me an error.

please can you help me, to understand what is wrong with my changes

[srbarba]

I'm sorry @JDavidVR but I only used this fix for my custom module. I didn't try to set it at core.

Reading the function I think you should use this fix AFTER the first validation:

protected function applyDesignConfig()
    {


        // Only run app emulation if this is the parent template and emulation isn't already running.
        // Otherwise child will run inside parent emulation.
        if ($this->isChildTemplate() || $this->hasDesignBeenApplied) {
            return false;
        }

        $areaObject = $this->_areaList->getArea($this->getDesignConfig()->getArea()); //<--------
        $areaObject->load(\Magento\Framework\App\Area::PART_TRANSLATE); //<------

        $this->hasDesignBeenApplied = true;

        $designConfig = $this->getDesignConfig();
        $storeId = $designConfig->getStore();
        $area = $designConfig->getArea();
        if ($storeId !== null) {
            // Force emulation in case email is being sent from same store so that theme will be loaded. Helpful
            // for situations where emails may be sent from bootstrap files that load frontend store, but not theme
            $this->appEmulation->startEnvironmentEmulation($storeId, $area, true);
        }
        return true;
    }

Can you share the given error?

[nobodypb]

@srbarba is right, but make sure to also change the constructor of
Magento\Email\Model\BackendTemplate
since Magento\Email\Model\Template::__construct is called there

[veloraven]

@nobodypb if this issue is still actual please describe it according to the Issue reporting guidelines: with steps to reproduce, actual result and expected result.

[veloraven]

According to contributor guide, tickets without response for two weeks should be closed.
If this issue still reproducible please feel free to create the new one: format new issue according to the Issue reporting guidelines: with steps to reproduce, actual result and expected result and specify Magento version.