[Issue] Add default empty array in constructor

[m2-assistant]

This issue is automatically created based on existing pull request: #38163: Add default empty array in constructor

---

Description (*)

This class its constructor argument $tagGenerators is empty by default in PHP, so that via DI argument types in di.xml files the array is filled automatically. This actually means that - without any runtime configuration of this argument - the PHP class has a required argument $tagGenerators.

In my cases, this is breaking DI compile when the modules Magento_DirectoryGraphQl and Magento_StoreGraphQl are disabled (and actually a lot of people will disable this module if they are not building a headless shop). This PR is a simple but required fix.

Related Pull Requests

None

Fixed Issues (if relevant)

None

Manual testing scenarios (*)

Install Magento 2. Next, add a composer replacement of magento/module-store-graph-ql and magento/module-directory-graph-ql and run composer update to remove these dependencies. Alternatively, just disable the modules Magento_DirectoryGraphQl and Magento_StoreGraphQl. Next, run bin/magento setup:di:compile. It should fail. With this patch, it should work.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[alpesh475]

@magento give me 2.4-develop instance - upcoming 2.4.x release

[magento-deployment-service]

Hi @alpesh475. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @alpesh475, here is your Magento Instance: https://173b0b5acc7ed3f56e8c4dcbfca1d2eb.instances-prod.magento-community.engineering
Admin access: https://173b0b5acc7ed3f56e8c4dcbfca1d2eb.instances-prod.magento-community.engineering/admin_8646
Login: 5c42ce0b
Password: d2f9d5cc6e17

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @jissereitsma,

Thanks for the report and collaboration!

We have tried to reproduce the issue in the 2.4-develop branch and the issue is reproducible for us after following the below steps:

1. Install Magento 2.4-develop
2. Disable the modules Magento_DirectoryGraphQl and Magento_StoreGraphQl via the below command:
   bin/magento module:disable Magento_DirectoryGraphQl Magento_StoreGraphQl
3. Then run the bin/magento setup:upgrade command.
4. The below error has been occurs:
   

Hence confirming the issue.

Thanks

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-10583 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[alpesh475]

give me 2.4-develop instance - upcoming 2.4.x release