Non-Static Customer Custom Attribute Are Always Updated When Using Customer Repository to Save

[NateSwanson7]

Preconditions and environment

• 2.4.7
• At least one non-static custom attribute for the customer entity

Steps to reproduce

1. Create a non-static customer custom attribute (e.g. my_custom_attribute)
2. Set my_custom_attribute to any value and save
3. Enable DB profiling
4. Load up the customer using the Customer Repository (\Magento\Customer\Api\CustomerRepositoryInterface)
5. Without changing any value save the customer using the Customer Repository (\Magento\Customer\Api\CustomerRepositoryInterface::save())
6. Check DB profiling results
7. Notice a query to insert the value that was already saved and set for your custom attribute my_custom_attribute even though the original value does not differ from the new value

Expected result

DB query to insert/update the value of the custom attribute is not created or ran because the value has not changed.

Actual result

DB query to insert/update the value of the custom attribute is created and ran even though the value does not differ.

Additional information

This can end up causing database deadlocks when the unnecessary insert/update query is ran which locks the row.

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @NateSwanson7. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[NateSwanson7]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @NateSwanson7. Thank you for your request. I'm working on Magento instance for you.

[NateSwanson7]

@magento I am working on this

[m2-assistant]

Hi @NateSwanson7! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

[NateSwanson7]

@magento add to contributors team

[m2-assistant]

Hi @NateSwanson7! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

[NateSwanson7]

@magento I am working on this

[magento-deployment-service]

Hi @NateSwanson7, here is your Magento Instance: https://38c5a955895e22f7c6495b2616fcecd6.instances-prod.magento-community.engineering
Admin access: https://38c5a955895e22f7c6495b2616fcecd6.instances-prod.magento-community.engineering/admin_31c7
Login: e95aaaae
Password: 727db6283fed

[m2-assistant]

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[m2-assistant]

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Hello @NateSwanson7,

Thank you for the report and collaboration!

We followed your steps to reproduce and created a not static customer custom attribute custom_field, but when saving the customer without changing any value led to below query:

SQL: INSERT  INTO `customer_grid_flat` (`entity_id`,`name`,`email`,`group_id`,`created_at`,`website_id`,`confirmation`,`created_in`,`dob`,`gender`,`taxvat`,`lock_expires`,`custom_field`,`shipping_full`,`billing_full`,`billing_firstname`,`billing_lastname`,`billing_telephone`,`billing_postcode`,`billing_country_id`,`billing_region`,`billing_region_id`,`billing_street`,`billing_city`,`billing_fax`,`billing_vat_id`,`billing_company`) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) ON DUPLICATE KEY UPDATE `name` = VALUES(`name`), `email` = VALUES(`email`), `group_id` = VALUES(`group_id`), `created_at` = VALUES(`created_at`), `website_id` = VALUES(`website_id`), `confirmation` = VALUES(`confirmation`), `created_in` = VALUES(`created_in`), `dob` = VALUES(`dob`), `gender` = VALUES(`gender`), `taxvat` = VALUES(`taxvat`), `lock_expires` = VALUES(`lock_expires`), `custom_field` = VALUES(`custom_field`), `shipping_full` = VALUES(`shipping_full`), `billing_full` = VALUES(`billing_full`), `billing_firstname` = VALUES(`billing_firstname`), `billing_lastname` = VALUES(`billing_lastname`), `billing_telephone` = VALUES(`billing_telephone`), `billing_postcode` = VALUES(`billing_postcode`), `billing_country_id` = VALUES(`billing_country_id`), `billing_region` = VALUES(`billing_region`), `billing_region_id` = VALUES(`billing_region_id`), `billing_street` = VALUES(`billing_street`), `billing_city` = VALUES(`billing_city`), `billing_fax` = VALUES(`billing_fax`), `billing_vat_id` = VALUES(`billing_vat_id`), `billing_company` = VALUES(`billing_company`)
BIND: array (
  0 => 1,
  1 => 'test test',
  2 => 'test@mail.com',
  3 => '1',
  4 => '2024-05-28 06:21:45',
  5 => '1',
  6 => NULL,
  7 => 'Default Store View',
  8 => NULL,
  9 => '0',
  10 => NULL,
  11 => NULL,
  12 => 'test data',
  13 => '',
  14 => '',
  15 => NULL,
  16 => NULL,
  17 => NULL,
  18 => NULL,
  19 => NULL,
  20 => NULL,
  21 => NULL,
  22 => NULL,
  23 => NULL,
  24 => NULL,
  25 => NULL,
  26 => NULL,
)
AFF: 1
TIME: 0.0008

We did not see a DB query specific to Customer Custom Attribute.

Please find the custom module used to reproduce this issue, and let us know if we are missing anyting.
I38753V.zip

Thank you.

[NateSwanson7]

@engcom-November I'll double check the steps I provided when I get a bit of time later this week.

Thanks

[sdouma]

@magento give me 2.4.4-p8 instance

[magento-deployment-service]

Hi @sdouma. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @sdouma, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

[sdouma]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @sdouma. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @sdouma, here is your Magento Instance: https://38c5a955895e22f7c6495b2616fcecd6.instances-prod.magento-community.engineering
Admin access: https://38c5a955895e22f7c6495b2616fcecd6.instances-prod.magento-community.engineering/admin_3549
Login: 49c3e35a
Password: b420e53203ba

[engcom-November]

Hello @NateSwanson7,

Can you give us any updates on this.

[NateSwanson7]

Hello @NateSwanson7,

Can you give us any updates on this.

@engcom-November I can't seem to reproduce this now, feel free to close this issue.