Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom attribute values to the origData property to prevent unnecessary db inserts and updates when saving the customer entity #38754

Closed

Conversation

NateSwanson7
Copy link

Description (*)

Prevents the creation and execution of unnecessary db inserts/updates when saving a customer entity when non-static customer custom attribute exist.

Fixed Issues (if relevant)

  1. Fixes Non-Static Customer Custom Attribute Are Always Updated When Using Customer Repository to Save #38753

Manual testing scenarios (*)

  1. Create a non-static customer custom attribute (e.g. my_custom_attribute)
  2. Set my_custom_attribute to any value and save
  3. Enable DB profiling
  4. Load up the customer using the Customer Repository (\Magento\Customer\Api\CustomerRepositoryInterface)
  5. Without changing any value save the customer using the Customer Repository (\Magento\Customer\Api\CustomerRepositoryInterface::save())
  6. Check DB profiling results
  7. Notice there is no longer a query to insert the value that was already saved and set for your custom attribute my_custom_attribute since the original value does not differ from the new value

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Copy link

m2-assistant bot commented May 24, 2024

Hi @NateSwanson7. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@NateSwanson7
Copy link
Author

@magento run all tests

2 similar comments
@NateSwanson7
Copy link
Author

@magento run all tests

@NateSwanson7
Copy link
Author

@magento run all tests

…essary db inserts and updates when saving the customer entity
@NateSwanson7
Copy link
Author

@magento run all tests

1 similar comment
@NateSwanson7
Copy link
Author

@magento run all tests

@NateSwanson7
Copy link
Author

@magento run all tests

@NateSwanson7
Copy link
Author

@magento run all tests

@engcom-November
Copy link
Contributor

Closing this pr as the linked issue is been closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-Static Customer Custom Attribute Are Always Updated When Using Customer Repository to Save
3 participants