Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: The Credit Memo Items' base_weee_tax_applied_row_amnt Value is Incorrect #38760

Open
wants to merge 3 commits into
base: 2.4-develop
Choose a base branch
from

Conversation

nicolasddev
Copy link

@nicolasddev nicolasddev commented May 26, 2024

The setBaseWeeeTaxAppliedRowAmnt() function should be used instead of setBaseWeeeTaxAppliedRowAmount, as the database table field name is base_weee_tax_applied_row_amnt. Due to this error, the value of the sales_creditmemo_item.base_weee_tax_applied_row_amnt database column is always set to the order item value, which is incorrect.

Manual testing scenarios (*)

  1. Backend: Create a product with a $50 Fixed Product Tax (FPT).
  2. Frontend: add 5 quantities of this product to your cart.
  3. Frontend: Make sure that the FPT are applied and place the order.
  4. Backend: Create a credit memo for only a single quantity.

Expected Result:
Since only a single quantity was credited, the values saved in both the sales_creditmemo_item.base_weee_tax_applied_amount and sales_creditmemo_item.base_weee_tax_applied_row_amnt columns should be 50.

Actual Result:
The values saved in the sales_creditmemo_item.base_weee_tax_applied_amount is 50 and sales_creditmemo_item.base_weee_tax_applied_row_amnt columns is 250 (5x 50).

Questions or comments

A developer must look at the base_weee_tax_applied_row_amnt column of the sales_creditmemo_item database table in order to confirm the result.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Fix: The Credit Memo Items' base_weee_tax_applied_row_amnt Value is Incorrect #38765: Fix: The Credit Memo Items' base_weee_tax_applied_row_amnt Value is Incorrect

…Incorrect

The setBaseWeeeTaxAppliedRowAmnt() function should be used instead of setBaseWeeeTaxAppliedRowAmount, as the database table field name is base_weee_tax_applied_row_amnt. Due to this error, the value of the sales_creditmemo_item.base_weee_tax_applied_row_amnt database column is always set to the order item value, which is incorrect.
Copy link

m2-assistant bot commented May 26, 2024

Hi @nicolasddev. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.

Add the comment under your pull request to deploy test or vanilla Magento instance:
  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@nicolasddev
Copy link
Author

@magento run all tests

@nicolasddev
Copy link
Author

@magento run Database Compare
@magento run Functional Tests B2B
@magento run Functional Tests CE
@magento run Functional Tests EE
@magento run Static Tests
@magento run Unit Tests
@magento run WebAPI Tests

@engcom-Charlie
Copy link
Contributor

@magento create issue

@engcom-Charlie engcom-Charlie added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: pending review
Projects
Status: Pending Review
Development

Successfully merging this pull request may close these issues.

[Issue] Fix: The Credit Memo Items' base_weee_tax_applied_row_amnt Value is Incorrect
2 participants