Fix type when validating field using attribute rules #38773
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
If attribute based rules are used to specify validation of a field in HTML, incorrect type is used when validating.
For example, validation rule is
ipv4
and has assigned a value of true and is processed as String, but should be Boolean instead.<input name="field" ipv4="true" ... />
Related Pull Requests
N/A
Fixed Issues (if relevant)
N/A
Manual testing scenarios (*)
custom-form.phtml
)rules
method:{ipv4: 'true'}
{ipv4: true}
Questions or comments
The PR has been elaborated in my article which describes the issue in more details: Deep Dive into Validation Rules
Contribution checklist (*)
Resolved issues: