Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isAdminSecure never used or missing code #4720

Closed
cdiacon opened this issue May 26, 2016 · 5 comments
Closed

isAdminSecure never used or missing code #4720

cdiacon opened this issue May 26, 2016 · 5 comments
Labels
bug report Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@cdiacon
Copy link

cdiacon commented May 26, 2016

This property is never used protected $_isAdminSecure = null;

Steps to reproduce

  1. Install Magento from develop branch.
  2. File Magento\Store\Model\Store.php line 209
    https://github.com/magento/magento2/blob/develop/app/code/Magento/Store/Model/Store.php#L209
  3. It looks like this flag is never used or there is missing code or should be moved to a new file?!?

Thanks.

@vkorotun vkorotun removed the PS label Aug 4, 2016
@magento-engcom-team magento-engcom-team added bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed TECH labels Sep 11, 2017
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Sep 11, 2017

@cdiacon thank you for your report.
Please use the issue reporting guidelines to report an issue. Please, edit issue description and include the preconditions, the steps required to reproduce, the actual result, and the expected result.
Please, add the following information:

  • Preconditions: Magento version
  • Steps to reproduce
  • Expected result
  • Actual result

@magento-engcom-team
Copy link
Contributor

Pull Request #10877 is created to address the issue

@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-75114

@magento-team magento-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development develop labels Sep 14, 2017
@magento-engcom-team
Copy link
Contributor

@cdiacon, thank you for your report.
The issue is already fixed in develop branch
But we will consider to backport the fix to patch releases

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Sep 20, 2017
@orlangur
Copy link
Contributor

@magento-engcom-team I don't think deprecations can be backported actually :)

magento-cicd2 pushed a commit that referenced this issue Oct 8, 2019
[TR] MC-19740: Set of InnoDB tables is converted to Memory tables after setup:upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

7 participants