Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation per module isn't working properly. #5682

Closed
tomsonnemans opened this issue Jul 18, 2016 · 3 comments
Closed

Translation per module isn't working properly. #5682

tomsonnemans opened this issue Jul 18, 2016 · 3 comments
Labels
bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed

Comments

@tomsonnemans
Copy link

tomsonnemans commented Jul 18, 2016

Steps to reproduce

  1. Install Magento CE. 2.1.0
  2. Add translations for separate modules with the "./bin/magento i18n:pack" command.
  3. Files are placed correctly.

Expected result

  1. "Remove","Verwijder",module,Magento_LayeredNavigation should be used for the filter remove button in the LayeredNavigation module.

Actual result

  1. "Remove","Verwijderen",module,Magento_Wishlist is used for the filter remove button in the LayeredNavigation module.

To conclude

The translation used in the LayeredNavigation module isn't from the LayeredNavigation i18n folder, but from the Wishlist i18n folder.

@maqlec
Copy link
Contributor

maqlec commented Nov 1, 2016

I confirm, when translation pack is present in app/i18n/Vendor/package or vendor directory then translations from separate modules are ignored. The worst is that Magento is getting latest translation from translation pack file while ignoring third and fourth column of CSV file.

Conclusion is that when you using translation pack you can't change translation in separate module without changing the translating everywhere

@MrDaar
Copy link

MrDaar commented Mar 18, 2017

Related to:
#6563

@magento-engcom-team magento-engcom-team added bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 11, 2017
@magento-engcom-team
Copy link
Contributor

Hi @tomsonnemans
Looks like this issue is already fixed in 2.2.0 with the following Pull request: #7142
Closing this ticket for now. Please reopen if the problem persists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed
Projects
None yet
Development

No branches or pull requests

5 participants